starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #958] [MERGED] feat: allow uppercase usernames #528

New Issue
Open
opened 2025-10-07 00:17:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:17:59 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/958
Author: @stonith404
Created: 9/17/2025
Status: ✅ Merged
Merged: 9/17/2025
Merged by: @kmendell

Base: main ← Head: feat/uppercase-username

📝 Commits (3)

📊 Changes

14 files changed (+71 additions, -27 deletions)

View changed files

📝 backend/internal/middleware/error_handler.go (+1 -1)
➖ backend/resources/migrations/postgres/20250829120000_user_display_name.down.sql (+0 -1)
➖ backend/resources/migrations/postgres/20250829120000_user_display_name.up.sql (+0 -6)
➕ backend/resources/migrations/postgres/20250917170000_user_display_name_and_username.down.sql (+3 -0)
➕ backend/resources/migrations/postgres/20250917170000_user_display_name_and_username.up.sql (+6 -0)
📝 backend/resources/migrations/sqlite/20250917170000_user_display_name_and_username.down.sql (+0 -0)
📝 backend/resources/migrations/sqlite/20250917170000_user_display_name_and_username.up.sql (+1 -1)
📝 frontend/messages/en.json (+2 -0)
📝 frontend/src/lib/components/signup/signup-form.svelte (+2 -6)
📝 frontend/src/lib/utils/zod-util.ts (+8 -0)
📝 frontend/src/routes/settings/account/account-form.svelte (+2 -6)
📝 frontend/src/routes/settings/admin/users/user-form.svelte (+2 -6)
📝 tests/specs/account-settings.spec.ts (+12 -0)
📝 tests/specs/user-settings.spec.ts (+32 -0)

📄 Description

This PR allows users to use uppercase letters in their usernames. The database index prevents the same username with different cases to avoid username confusion.

Closes #906, #909

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/958 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 9/17/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `feat/uppercase-username` --- ### 📝 Commits (3) - [`6c857cf`](https://github.com/pocket-id/pocket-id/commit/6c857cf1c770c7e3cf97f1319b6e524e61667758) feat: allow uppercase usernames - [`fc20b0b`](https://github.com/pocket-id/pocket-id/commit/fc20b0bc0240de401de3f74fc5fd76f88e3ba831) use CITEXT for username - [`986de79`](https://github.com/pocket-id/pocket-id/commit/986de7997cd2c91cb8f7db0ea43641d92a3db62b) add e2e tests ### 📊 Changes **14 files changed** (+71 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/middleware/error_handler.go` (+1 -1) ➖ `backend/resources/migrations/postgres/20250829120000_user_display_name.down.sql` (+0 -1) ➖ `backend/resources/migrations/postgres/20250829120000_user_display_name.up.sql` (+0 -6) ➕ `backend/resources/migrations/postgres/20250917170000_user_display_name_and_username.down.sql` (+3 -0) ➕ `backend/resources/migrations/postgres/20250917170000_user_display_name_and_username.up.sql` (+6 -0) 📝 `backend/resources/migrations/sqlite/20250917170000_user_display_name_and_username.down.sql` (+0 -0) 📝 `backend/resources/migrations/sqlite/20250917170000_user_display_name_and_username.up.sql` (+1 -1) 📝 `frontend/messages/en.json` (+2 -0) 📝 `frontend/src/lib/components/signup/signup-form.svelte` (+2 -6) 📝 `frontend/src/lib/utils/zod-util.ts` (+8 -0) 📝 `frontend/src/routes/settings/account/account-form.svelte` (+2 -6) 📝 `frontend/src/routes/settings/admin/users/user-form.svelte` (+2 -6) 📝 `tests/specs/account-settings.spec.ts` (+12 -0) 📝 `tests/specs/user-settings.spec.ts` (+32 -0) </details> ### 📄 Description This PR allows users to use uppercase letters in their usernames. The database index prevents the same username with different cases to avoid username confusion. Closes #906, #909 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:17:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#528
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?