starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 01:10:22 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #222] [MERGED] fix: user linking in ldap group sync #906

New Issue
Open
opened 2025-10-07 00:24:26 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:24:26 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/222
Author: @kmendell
Created: 2/9/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @stonith404

Base: main ← Head: ldap-group-sync-fix

📝 Commits (2)

  • 63419b3 add ldap_id check for syncing users into ldap groups
  • 458b297 remove old db query

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 backend/internal/service/ldap_service.go (+2 -1)

📄 Description

Added a missed check for syncing ldap users into ldap groups. we were not checking for the ldap_id when trying to add user into the group which could cause a sync fail.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/222 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 2/9/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `ldap-group-sync-fix` --- ### 📝 Commits (2) - [`63419b3`](https://github.com/pocket-id/pocket-id/commit/63419b3d453b176dd4d684173e75b7cfd15c46f9) add ldap_id check for syncing users into ldap groups - [`458b297`](https://github.com/pocket-id/pocket-id/commit/458b297113d524e0771fe6e5e0d9e8945422192f) remove old db query ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/ldap_service.go` (+2 -1) </details> ### 📄 Description Added a missed check for syncing ldap users into ldap groups. we were not checking for the ldap_id when trying to add user into the group which could cause a sync fail. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:24:26 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#906
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?