starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-02-05 00:39:38 +03:00
Code Issues 61 Packages Projects Releases 10 Wiki Activity

[PR #734] [MERGED] refactor: use react email for email templates #909

New Issue
Closed
opened 2026-02-04 21:03:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 21:03:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/734
Author: @kmendell
Created: 7/8/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @stonith404

Base: main ← Head: feat/react-email

📝 Commits (10+)

📊 Changes

33 files changed (+5198 additions, -442 deletions)

View changed files

📝 .github/workflows/build-next.yml (+0 -2)
📝 .github/workflows/e2e-tests.yml (+7 -9)
📝 .github/workflows/release.yml (+1 -2)
📝 .github/workflows/svelte-check.yml (+0 -2)
📝 backend/.golangci.yml (+1 -1)
📝 backend/internal/service/email_service.go (+5 -6)
📝 backend/internal/utils/email/email_service_templates.go (+12 -49)
📝 backend/resources/email-templates/api-key-expiring-soon_html.tmpl (+3 -17)
📝 backend/resources/email-templates/api-key-expiring-soon_text.tmpl (+9 -7)
➖ backend/resources/email-templates/components/email_html.tmpl (+0 -14)
➖ backend/resources/email-templates/components/email_text.tmpl (+0 -7)
➖ backend/resources/email-templates/components/style_html.tmpl (+0 -92)
📝 backend/resources/email-templates/login-with-new-device_html.tmpl (+5 -40)
📝 backend/resources/email-templates/login-with-new-device_text.tmpl (+27 -15)
📝 backend/resources/email-templates/one-time-access_html.tmpl (+4 -17)
📝 backend/resources/email-templates/one-time-access_text.tmpl (+9 -7)
📝 backend/resources/email-templates/test_html.tmpl (+3 -11)
📝 backend/resources/email-templates/test_text.tmpl (+6 -3)
📝 backend/resources/files.go (+1 -1)
➕ email-templates/build.ts (+115 -0)

...and 13 more files

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/722

Summary by CodeRabbit

  • New Features

    • Revamped HTML/text email templates with a consistent design and footer.
    • Enhanced “API Key Expiring Soon,” “Login with New Device,” “One-Time Access,” and “Test” emails.

  • Bug Fixes

    • Corrected email MIME headers and encodings for improved deliverability and rendering.

  • Refactor

    • Simplified email template loading for faster, more reliable rendering.

  • Chores

    • CI/CD now builds email templates during image and release builds.
    • E2E workflows updated; test reports uploaded from a new path.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/734 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/react-email` --- ### 📝 Commits (10+) - [`65e5de1`](https://github.com/pocket-id/pocket-id/commit/65e5de1c963ea3dc6b7e9f148981cd9dc6d2208e) feat: use react email for email templates - [`dca9087`](https://github.com/pocket-id/pocket-id/commit/dca90879295148c5ad40e150dfd23049d1486d24) test new styling - [`434c983`](https://github.com/pocket-id/pocket-id/commit/434c983498713afd5dde1ce2f953c67557161f70) update table styling - [`c602b99`](https://github.com/pocket-id/pocket-id/commit/c602b9904b8fac9c23629bdb3170521627b7d422) update styles again - [`607de1d`](https://github.com/pocket-id/pocket-id/commit/607de1d2a6c508c6bb9e8d2b3d0e2b5a6698dad6) update build script - [`acc39e3`](https://github.com/pocket-id/pocket-id/commit/acc39e3d5ae8f8cad60d0a9ce1bc0da1bcf96981) use div over sections - [`1c02a62`](https://github.com/pocket-id/pocket-id/commit/1c02a62abe568e4a3527636ffc124bfa95344c22) replace container with div - [`9ba4f64`](https://github.com/pocket-id/pocket-id/commit/9ba4f643c52a65ae45983d9c04e19a2f879700b2) simplify build script - [`35db96f`](https://github.com/pocket-id/pocket-id/commit/35db96f3de0e33b8689d1ccf4b1362f450a1d942) fix padding and build - [`1cf5be9`](https://github.com/pocket-id/pocket-id/commit/1cf5be9072c31ca430b184ce86b3bcc487da3038) Merge branch 'main' into feat/react-email ### 📊 Changes **33 files changed** (+5198 additions, -442 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-next.yml` (+0 -2) 📝 `.github/workflows/e2e-tests.yml` (+7 -9) 📝 `.github/workflows/release.yml` (+1 -2) 📝 `.github/workflows/svelte-check.yml` (+0 -2) 📝 `backend/.golangci.yml` (+1 -1) 📝 `backend/internal/service/email_service.go` (+5 -6) 📝 `backend/internal/utils/email/email_service_templates.go` (+12 -49) 📝 `backend/resources/email-templates/api-key-expiring-soon_html.tmpl` (+3 -17) 📝 `backend/resources/email-templates/api-key-expiring-soon_text.tmpl` (+9 -7) ➖ `backend/resources/email-templates/components/email_html.tmpl` (+0 -14) ➖ `backend/resources/email-templates/components/email_text.tmpl` (+0 -7) ➖ `backend/resources/email-templates/components/style_html.tmpl` (+0 -92) 📝 `backend/resources/email-templates/login-with-new-device_html.tmpl` (+5 -40) 📝 `backend/resources/email-templates/login-with-new-device_text.tmpl` (+27 -15) 📝 `backend/resources/email-templates/one-time-access_html.tmpl` (+4 -17) 📝 `backend/resources/email-templates/one-time-access_text.tmpl` (+9 -7) 📝 `backend/resources/email-templates/test_html.tmpl` (+3 -11) 📝 `backend/resources/email-templates/test_text.tmpl` (+6 -3) 📝 `backend/resources/files.go` (+1 -1) ➕ `email-templates/build.ts` (+115 -0) _...and 13 more files_ </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/722 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Revamped HTML/text email templates with a consistent design and footer. - Enhanced “API Key Expiring Soon,” “Login with New Device,” “One-Time Access,” and “Test” emails. - Bug Fixes - Corrected email MIME headers and encodings for improved deliverability and rendering. - Refactor - Simplified email template loading for faster, more reliable rendering. - Chores - CI/CD now builds email templates during image and release builds. - E2E workflows updated; test reports uploaded from a new path. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:03:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
bug
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#909
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?