[PR #1845] [MERGED] Add close icon to notifications #5909

New Issue

OVERLORD · 2026-02-05T10:20:06+03:00

OVERLORD commented

2026-02-05 10:20:06 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1845
Author: @SoarinFerret
Created: 1/14/2020
Status: ✅ Merged
Merged: 1/19/2020
Merged by: @ssddanbrown

Base: master ← Head: add-close-icon-to-notifications

📝 Commits (1)

4297d64 Add close icon to notifications

📊 Changes

2 files changed (+11 additions, -4 deletions)

View changed files

📝 resources/sass/_components.scss (+8 -1)
📝 resources/views/partials/notifications.blade.php (+3 -3)

📄 Description

In relation to #1525

This adds a simple close icon to all notification panes. Here is an example of how it looks:

Per the comments on the bottom of the issue thread, it doesn't actually do anything, besides provide the user a visual cue reminding users to click to dismiss the notification.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1845 **Author:** [@SoarinFerret](https://github.com/SoarinFerret) **Created:** 1/14/2020 **Status:** ✅ Merged **Merged:** 1/19/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `add-close-icon-to-notifications` --- ### 📝 Commits (1) - [`4297d64`](https://github.com/BookStackApp/BookStack/commit/4297d64e299eacfafdb96e1d98ea338c7ba310ad) Add close icon to notifications ### 📊 Changes **2 files changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `resources/sass/_components.scss` (+8 -1) 📝 `resources/views/partials/notifications.blade.php` (+3 -3) </details> ### 📄 Description In relation to #1525 This adds a simple close icon to all notification panes. Here is an example of how it looks: ![image](https://user-images.githubusercontent.com/33401067/72377597-5fb73e80-36d5-11ea-8655-e1881383d8c0.png) Per the comments on the bottom of the issue thread, it doesn't actually do anything, besides provide the user a visual cue reminding users to click to dismiss the notification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:20:06 +03:00

OVERLORD closed this issue

2026-02-05 10:20:11 +03:00

OVERLORD referenced this issue

2026-02-05 10:36:13 +03:00

[PR #5909] [MERGED] Images: Updated access to consider public secure_restricted #6590

Sign in to join this conversation.