[PR #5909] [MERGED] Images: Updated access to consider public secure_restricted #6590

New Issue

OVERLORD · 2026-02-05T10:36:13+03:00

OVERLORD commented

2026-02-05 10:36:13 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5909
Author: @ssddanbrown
Created: 11/21/2025
Status: ✅ Merged
Merged: 11/21/2025
Merged by: @ssddanbrown

Base: development ← Head: image_access_v2

📝 Commits (2)

73c6bf4 Images: Updated access to consider public secure_restricted
9934f85 Deps: Updated PHP packages via composer

📊 Changes

4 files changed (+95 additions, -30 deletions)

View changed files

📝 app/Uploads/ImageService.php (+13 -2)
📝 app/Uploads/ImageStorage.php (+1 -1)
📝 composer.lock (+27 -27)
📝 tests/Uploads/ImageTest.php (+54 -0)

📄 Description

Had prevented public access for images when secure_restricted images was enabled (and for just secure images) when app settings allowed public access.

This considers the app public setting, and adds tests to cover extra scenarios to prevent regression.

Related to #5906

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5909 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 11/21/2025 **Status:** ✅ Merged **Merged:** 11/21/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `image_access_v2` --- ### 📝 Commits (2) - [`73c6bf4`](https://github.com/BookStackApp/BookStack/commit/73c6bf4f8deea1eaf417b3ac929c0e817a203128) Images: Updated access to consider public secure_restricted - [`9934f85`](https://github.com/BookStackApp/BookStack/commit/9934f85ba93a9450b2a7a02559e658c5181aca61) Deps: Updated PHP packages via composer ### 📊 Changes **4 files changed** (+95 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `app/Uploads/ImageService.php` (+13 -2) 📝 `app/Uploads/ImageStorage.php` (+1 -1) 📝 `composer.lock` (+27 -27) 📝 `tests/Uploads/ImageTest.php` (+54 -0) </details> ### 📄 Description Had prevented public access for images when secure_restricted images was enabled (and for just secure images) when app settings allowed public access. This considers the app public setting, and adds tests to cover extra scenarios to prevent regression. Related to #5906 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:36:13 +03:00

OVERLORD closed this issue

2026-02-05 10:36:14 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6590