starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-07 19:06:05 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

[PR #340] [MERGED] [WIP] Implementation of new search system #5631

New Issue
Closed
opened 2026-02-05 10:12:48 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:12:48 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/340
Author: @ssddanbrown
Created: 3/19/2017
Status: ✅ Merged
Merged: 4/16/2017
Merged by: @ssddanbrown

Base: master ← Head: search_system

📝 Commits (10+)

  • 070d4ae Started implementation of new search system
  • 1552417 Developed basic search queries.
  • 0651eae Improve efficiency of single entity search indexing
  • 3313053 Added search term parsing and exact term matches
  • 01cb22a Added tag searches and advanced filters to new search
  • 37813a2 Improved DB prefix support and removed old search method
  • 1338ae2 Started search interface, Added in vue and moved fonts
  • 46f3d78 Fixed entity type filter bug in new search system
  • ad12532 Migrated to custom gulp setup and conintue search interface
  • 0e0945e Finished off UI for search system

📊 Changes

46 files changed (+1552 additions, -613 deletions)

View changed files

📝 app/Book.php (+9 -0)
📝 app/Chapter.php (+9 -0)
📝 app/Console/Commands/RegeneratePermissions.php (+8 -1)
➕ app/Console/Commands/RegenerateSearch.php (+53 -0)
📝 app/Console/Kernel.php (+6 -7)
📝 app/Entity.php (+19 -58)
📝 app/Http/Controllers/SearchController.php (+33 -84)
📝 app/Page.php (+11 -2)
📝 app/Repos/EntityRepo.php (+22 -155)
➕ app/SearchTerm.php (+18 -0)
📝 app/Services/PermissionService.php (+4 -5)
➕ app/Services/SearchService.php (+472 -0)
📝 database/migrations/2015_08_31_175240_add_search_indexes.php (+4 -3)
📝 database/migrations/2015_12_05_145049_fulltext_weighting.php (+4 -3)
➕ database/migrations/2017_03_19_091553_create_search_index_table.php (+63 -0)
📝 database/seeds/DummyContentSeeder.php (+3 -3)
📝 gulpfile.js (+61 -6)
📝 package.json (+29 -10)
📝 resources/assets/js/controllers.js (+4 -37)
📝 resources/assets/js/directives.js (+3 -3)

...and 26 more files

📄 Description

Will close the following issues:

  • #271 - Replace current search solution
  • #344 - Search within chapters
  • #285 - Random Bad search behaviour
  • #269 - Problem with searching terms with accents
  • #64 - Powerful custom page search/filter/ordering interface

Progress

  • Database setup
  • Text searches
  • Tag searches
  • Search Filters
  • Advanced search/filtering UI on search page
  • Search within chapters
  • Tests to cover Search System
  • Update docs detailing search syntax

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/340 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 3/19/2017 **Status:** ✅ Merged **Merged:** 4/16/2017 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `search_system` --- ### 📝 Commits (10+) - [`070d4ae`](https://github.com/BookStackApp/BookStack/commit/070d4aeb6ca9af987c551aede0e3b37688a0808e) Started implementation of new search system - [`1552417`](https://github.com/BookStackApp/BookStack/commit/15524175988bd9d8019d0baa5cbd7965f0b19b91) Developed basic search queries. - [`0651eae`](https://github.com/BookStackApp/BookStack/commit/0651eae7ecdeb3b0781ed1231d601d936603e07d) Improve efficiency of single entity search indexing - [`3313053`](https://github.com/BookStackApp/BookStack/commit/331305333d354dc58dd67d65c6494da83b60ecfe) Added search term parsing and exact term matches - [`01cb22a`](https://github.com/BookStackApp/BookStack/commit/01cb22af37535d9d12d76a56413fdb645568972a) Added tag searches and advanced filters to new search - [`37813a2`](https://github.com/BookStackApp/BookStack/commit/37813a223a47b63570e975604119a209deac2733) Improved DB prefix support and removed old search method - [`1338ae2`](https://github.com/BookStackApp/BookStack/commit/1338ae2fc339cfcc0605d1a74db570e08311736c) Started search interface, Added in vue and moved fonts - [`46f3d78`](https://github.com/BookStackApp/BookStack/commit/46f3d78c8a9b8aa25c43d2449eb78e949d1dcc7e) Fixed entity type filter bug in new search system - [`ad12532`](https://github.com/BookStackApp/BookStack/commit/ad125327c040830596736f9ac48f97763836318d) Migrated to custom gulp setup and conintue search interface - [`0e0945e`](https://github.com/BookStackApp/BookStack/commit/0e0945ef8465adaf1a195d729c4bdc9e8c37de60) Finished off UI for search system ### 📊 Changes **46 files changed** (+1552 additions, -613 deletions) <details> <summary>View changed files</summary> 📝 `app/Book.php` (+9 -0) 📝 `app/Chapter.php` (+9 -0) 📝 `app/Console/Commands/RegeneratePermissions.php` (+8 -1) ➕ `app/Console/Commands/RegenerateSearch.php` (+53 -0) 📝 `app/Console/Kernel.php` (+6 -7) 📝 `app/Entity.php` (+19 -58) 📝 `app/Http/Controllers/SearchController.php` (+33 -84) 📝 `app/Page.php` (+11 -2) 📝 `app/Repos/EntityRepo.php` (+22 -155) ➕ `app/SearchTerm.php` (+18 -0) 📝 `app/Services/PermissionService.php` (+4 -5) ➕ `app/Services/SearchService.php` (+472 -0) 📝 `database/migrations/2015_08_31_175240_add_search_indexes.php` (+4 -3) 📝 `database/migrations/2015_12_05_145049_fulltext_weighting.php` (+4 -3) ➕ `database/migrations/2017_03_19_091553_create_search_index_table.php` (+63 -0) 📝 `database/seeds/DummyContentSeeder.php` (+3 -3) 📝 `gulpfile.js` (+61 -6) 📝 `package.json` (+29 -10) 📝 `resources/assets/js/controllers.js` (+4 -37) 📝 `resources/assets/js/directives.js` (+3 -3) _...and 26 more files_ </details> ### 📄 Description Will close the following issues: * #271 - Replace current search solution * #344 - Search within chapters * #285 - Random Bad search behaviour * #269 - Problem with searching terms with accents * #64 - Powerful custom page search/filter/ordering interface ### Progress - [x] Database setup - [x] Text searches - [x] Tag searches - [x] Search Filters - [x] Advanced search/filtering UI on search page - [x] Search within chapters - [x] Tests to cover Search System - [x] Update docs detailing search syntax --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:12:48 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5631
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?