[PR #5731] [MERGED] New WYSIWYG editor changes for July 2025 #6561

Closed
opened 2026-02-05 10:35:34 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5731
Author: @ssddanbrown
Created: 7/24/2025
Status: Merged
Merged: 7/26/2025
Merged by: @ssddanbrown

Base: developmentHead: lexical_jul25


📝 Commits (5)

  • 5fc19b0 Lexical: Fixed highlight format action, changed label
  • ae4d1d8 Lexical: Table cell bg and format setting fixes
  • 865e5ae Lexical: Source code input changes
  • c54101c Lexical: Updated URL handling, added mouse handling
  • d145efb Lexical: Updated tests after link changes

📊 Changes

18 files changed (+197 additions, -81 deletions)

View changed files

📝 lang/en/editor.php (+1 -0)
📝 resources/js/wysiwyg/index.ts (+2 -0)
📝 resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts (+16 -0)
📝 resources/js/wysiwyg/lexical/html/__tests__/unit/LexicalHtml.test.ts (+1 -1)
📝 resources/js/wysiwyg/lexical/html/index.ts (+12 -1)
📝 resources/js/wysiwyg/lexical/link/__tests__/unit/LexicalAutoLinkNode.test.ts (+0 -12)
📝 resources/js/wysiwyg/lexical/link/__tests__/unit/LexicalLinkNode.test.ts (+0 -12)
📝 resources/js/wysiwyg/lexical/link/index.ts (+1 -22)
📝 resources/js/wysiwyg/lexical/table/LexicalTableCellNode.ts (+8 -1)
📝 resources/js/wysiwyg/lexical/utils/__tests__/unit/LexicalUtilsSplitNode.test.ts (+6 -6)
📝 resources/js/wysiwyg/lexical/utils/__tests__/unit/LexlcaiUtilsInsertNodeToNearestRoot.test.ts (+14 -14)
resources/js/wysiwyg/services/__tests__/mouse-handling.test.ts (+51 -0)
resources/js/wysiwyg/services/mouse-handling.ts (+63 -0)
📝 resources/js/wysiwyg/services/shortcuts.ts (+9 -7)
📝 resources/js/wysiwyg/ui/defaults/buttons/inline-formats.ts (+2 -3)
📝 resources/js/wysiwyg/ui/defaults/forms/tables.ts (+2 -2)
📝 resources/js/wysiwyg/utils/tables.ts (+1 -0)
📝 resources/sass/_editor.scss (+8 -0)

📄 Description

Related to #5631

Changes

  • Fixed text highlight action & updated label.
  • Fixed unstable table cell background colors.
  • Fixed incorrect header levels used via format shortcuts.
  • Fixed UI menu not reflecting block format changes.
  • Fixed URLs not allowing any protocol as per old editor.
  • Updated source code popup with larger input.
  • Updated source code generation with newlines between top-level blocks.
  • Added ability to insert new paragraph on click under certain last hard-to-escape blocks (tables, drawings etc...).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5731 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 7/24/2025 **Status:** ✅ Merged **Merged:** 7/26/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `lexical_jul25` --- ### 📝 Commits (5) - [`5fc19b0`](https://github.com/BookStackApp/BookStack/commit/5fc19b0edf3cf4bf88e54ff11c63a82d8664218f) Lexical: Fixed highlight format action, changed label - [`ae4d1d8`](https://github.com/BookStackApp/BookStack/commit/ae4d1d804a8dbe3e95511afb2470e36a0d4a38fa) Lexical: Table cell bg and format setting fixes - [`865e5ae`](https://github.com/BookStackApp/BookStack/commit/865e5aecc99ebb8051f7b1c99b11710bd9709383) Lexical: Source code input changes - [`c54101c`](https://github.com/BookStackApp/BookStack/commit/c54101c603a3e8e06c372de673a811d41a1f1f9d) Lexical: Updated URL handling, added mouse handling - [`d145efb`](https://github.com/BookStackApp/BookStack/commit/d145efb6f6eac73947c7f3c53173f42b4dd9a615) Lexical: Updated tests after link changes ### 📊 Changes **18 files changed** (+197 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `lang/en/editor.php` (+1 -0) 📝 `resources/js/wysiwyg/index.ts` (+2 -0) 📝 `resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts` (+16 -0) 📝 `resources/js/wysiwyg/lexical/html/__tests__/unit/LexicalHtml.test.ts` (+1 -1) 📝 `resources/js/wysiwyg/lexical/html/index.ts` (+12 -1) 📝 `resources/js/wysiwyg/lexical/link/__tests__/unit/LexicalAutoLinkNode.test.ts` (+0 -12) 📝 `resources/js/wysiwyg/lexical/link/__tests__/unit/LexicalLinkNode.test.ts` (+0 -12) 📝 `resources/js/wysiwyg/lexical/link/index.ts` (+1 -22) 📝 `resources/js/wysiwyg/lexical/table/LexicalTableCellNode.ts` (+8 -1) 📝 `resources/js/wysiwyg/lexical/utils/__tests__/unit/LexicalUtilsSplitNode.test.ts` (+6 -6) 📝 `resources/js/wysiwyg/lexical/utils/__tests__/unit/LexlcaiUtilsInsertNodeToNearestRoot.test.ts` (+14 -14) ➕ `resources/js/wysiwyg/services/__tests__/mouse-handling.test.ts` (+51 -0) ➕ `resources/js/wysiwyg/services/mouse-handling.ts` (+63 -0) 📝 `resources/js/wysiwyg/services/shortcuts.ts` (+9 -7) 📝 `resources/js/wysiwyg/ui/defaults/buttons/inline-formats.ts` (+2 -3) 📝 `resources/js/wysiwyg/ui/defaults/forms/tables.ts` (+2 -2) 📝 `resources/js/wysiwyg/utils/tables.ts` (+1 -0) 📝 `resources/sass/_editor.scss` (+8 -0) </details> ### 📄 Description Related to #5631 ### Changes - Fixed text highlight action & updated label. - Fixed unstable table cell background colors. - Fixed incorrect header levels used via format shortcuts. - Fixed UI menu not reflecting block format changes. - Fixed URLs not allowing any protocol as per old editor. - Updated source code popup with larger input. - Updated source code generation with newlines between top-level blocks. - Added ability to insert new paragraph on click under certain last hard-to-escape blocks (tables, drawings etc...). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:35:34 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6561