[PR #5653] [MERGED] Lexical Fixes for v25.05.1 #6539

New Issue

OVERLORD · 2026-02-05T10:34:59+03:00

OVERLORD commented

2026-02-05 10:34:59 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5653
Author: @ssddanbrown
Created: 6/13/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @ssddanbrown

Base: development ← Head: v25-05-1-lexical

📝 Commits (7)

fda242d Lexical: Fixed tiny image resizer on image insert
717b516 Lexical: Made table resize handles more efficent & less buggy
8b062d4 Lexical: Fixed strange paragraph formatting behaviour
77a8861 Lexical: Fixed double-bold text, updated tests
8d4b8ff Lexical: Fixed media resize handling
1611b03 Lexical: Added a media toolbar, improved toolbars and media selection
b913ae7 Lexical: Media form improvements

📊 Changes

24 files changed (+283 additions, -72 deletions)

View changed files

📝 resources/js/wysiwyg/index.ts (+1 -1)
📝 resources/js/wysiwyg/lexical/core/LexicalEvents.ts (+1 -0)
📝 resources/js/wysiwyg/lexical/core/__tests__/unit/LexicalEditor.test.ts (+2 -0)
📝 resources/js/wysiwyg/lexical/core/__tests__/unit/LexicalEditorState.test.ts (+2 -1)
📝 resources/js/wysiwyg/lexical/core/__tests__/unit/LexicalSerialization.test.ts (+2 -2)
📝 resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts (+2 -0)
📝 resources/js/wysiwyg/lexical/core/nodes/LexicalParagraphNode.ts (+24 -1)
📝 resources/js/wysiwyg/lexical/core/nodes/LexicalTextNode.ts (+3 -2)
📝 resources/js/wysiwyg/lexical/core/nodes/__tests__/unit/LexicalParagraphNode.test.ts (+1 -0)
📝 resources/js/wysiwyg/lexical/core/nodes/__tests__/unit/LexicalTextNode.test.ts (+1 -1)
📝 resources/js/wysiwyg/lexical/rich-text/LexicalMediaNode.ts (+37 -18)
➕ resources/js/wysiwyg/lexical/rich-text/__tests__/unit/LexicalMediaNode.test.ts (+46 -0)
📝 resources/js/wysiwyg/lexical/table/__tests__/unit/LexicalTableSelection.test.ts (+1 -0)
📝 resources/js/wysiwyg/ui/defaults/buttons/objects.ts (+1 -0)
📝 resources/js/wysiwyg/ui/defaults/forms/objects.ts (+16 -3)
📝 resources/js/wysiwyg/ui/defaults/toolbars.ts (+4 -0)
📝 resources/js/wysiwyg/ui/framework/forms.ts (+4 -1)
📝 resources/js/wysiwyg/ui/framework/helpers/node-resizer.ts (+59 -32)
📝 resources/js/wysiwyg/ui/framework/helpers/table-resizer.ts (+36 -3)
📝 resources/js/wysiwyg/ui/framework/toolbars.ts (+5 -1)

...and 4 more files

📄 Description

For #5631

Fixed tiny image resize square on image insert.
Updated table resize handles to be more efficient, and prevented them wondering far away from tables so often.
Fixed table resize handles overlapping table captions.
Fixed text formatting being inconsistent on new paragraphs.
Updated media resize handling to be more reliable and to retain focus after resize.
Added toolbar for media element for easier menu access.
Fixed buggy media selection scenarios.
Fixed media form "src" field not working when video is using source elements.
Updated media embed code field to show existing embed code for direct editing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5653 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 6/13/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `v25-05-1-lexical` --- ### 📝 Commits (7) - [`fda242d`](https://github.com/BookStackApp/BookStack/commit/fda242d3da40b1352298bf6ddf3fc902b7690e3b) Lexical: Fixed tiny image resizer on image insert - [`717b516`](https://github.com/BookStackApp/BookStack/commit/717b5163414124422899d4270e41db4267e316c9) Lexical: Made table resize handles more efficent & less buggy - [`8b062d4`](https://github.com/BookStackApp/BookStack/commit/8b062d47951825e04f9a65ea3b09d9c70ee8b59d) Lexical: Fixed strange paragraph formatting behaviour - [`77a8861`](https://github.com/BookStackApp/BookStack/commit/77a88618c21d66cf663bb37979260539df7528e3) Lexical: Fixed double-bold text, updated tests - [`8d4b8ff`](https://github.com/BookStackApp/BookStack/commit/8d4b8ff4f375c014d36ccbf034dfc77bb8481804) Lexical: Fixed media resize handling - [`1611b03`](https://github.com/BookStackApp/BookStack/commit/1611b0399f2ccfcf5f261642a12076cde91b9600) Lexical: Added a media toolbar, improved toolbars and media selection - [`b913ae7`](https://github.com/BookStackApp/BookStack/commit/b913ae703deb29c0e4bca42a0d8938587dbc2e75) Lexical: Media form improvements ### 📊 Changes **24 files changed** (+283 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `resources/js/wysiwyg/index.ts` (+1 -1) 📝 `resources/js/wysiwyg/lexical/core/LexicalEvents.ts` (+1 -0) 📝 `resources/js/wysiwyg/lexical/core/__tests__/unit/LexicalEditor.test.ts` (+2 -0) 📝 `resources/js/wysiwyg/lexical/core/__tests__/unit/LexicalEditorState.test.ts` (+2 -1) 📝 `resources/js/wysiwyg/lexical/core/__tests__/unit/LexicalSerialization.test.ts` (+2 -2) 📝 `resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts` (+2 -0) 📝 `resources/js/wysiwyg/lexical/core/nodes/LexicalParagraphNode.ts` (+24 -1) 📝 `resources/js/wysiwyg/lexical/core/nodes/LexicalTextNode.ts` (+3 -2) 📝 `resources/js/wysiwyg/lexical/core/nodes/__tests__/unit/LexicalParagraphNode.test.ts` (+1 -0) 📝 `resources/js/wysiwyg/lexical/core/nodes/__tests__/unit/LexicalTextNode.test.ts` (+1 -1) 📝 `resources/js/wysiwyg/lexical/rich-text/LexicalMediaNode.ts` (+37 -18) ➕ `resources/js/wysiwyg/lexical/rich-text/__tests__/unit/LexicalMediaNode.test.ts` (+46 -0) 📝 `resources/js/wysiwyg/lexical/table/__tests__/unit/LexicalTableSelection.test.ts` (+1 -0) 📝 `resources/js/wysiwyg/ui/defaults/buttons/objects.ts` (+1 -0) 📝 `resources/js/wysiwyg/ui/defaults/forms/objects.ts` (+16 -3) 📝 `resources/js/wysiwyg/ui/defaults/toolbars.ts` (+4 -0) 📝 `resources/js/wysiwyg/ui/framework/forms.ts` (+4 -1) 📝 `resources/js/wysiwyg/ui/framework/helpers/node-resizer.ts` (+59 -32) 📝 `resources/js/wysiwyg/ui/framework/helpers/table-resizer.ts` (+36 -3) 📝 `resources/js/wysiwyg/ui/framework/toolbars.ts` (+5 -1) _...and 4 more files_ </details> ### 📄 Description For #5631 - Fixed tiny image resize square on image insert. - Updated table resize handles to be more efficient, and prevented them wondering far away from tables so often. - Fixed table resize handles overlapping table captions. - Fixed text formatting being inconsistent on new paragraphs. - Updated media resize handling to be more reliable and to retain focus after resize. - Added toolbar for media element for easier menu access. - Fixed buggy media selection scenarios. - Fixed media form "src" field not working when video is using source elements. - Updated media embed code field to show existing embed code for direct editing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:34:59 +03:00

OVERLORD closed this issue

2026-02-05 10:35:02 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6539