immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4697] [MERGED] fix(mobile): first char miss in new description #10484

New Issue
Closed
opened 2026-02-05 14:22:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:22:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4697
Author: @shenlong-tanwen
Created: 10/29/2023
Status: ✅ Merged
Merged: 10/29/2023
Merged by: @alextran1502

Base: main ← Head: fix/description-text-miss

📝 Commits (1)

  • bdc6ed4 fix(mobile): first char miss in new description

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 mobile/lib/modules/asset_viewer/ui/description_input.dart (+8 -1)

📄 Description

Fixes #4691

Issue

The controller's text was set to the description value from remote on each widget rebuilds. When the first character is typed, a state variable isTextEmpty is updated, which triggers a rebuild and thereby emptying the controller's text. This results in the first character typed by the user getting missed out.

Change made in the PR

The controller's text value is now updated only on the first build and only if the remote description is updated in the subsequent rebuilds.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4697 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 10/29/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/description-text-miss` --- ### 📝 Commits (1) - [`bdc6ed4`](https://github.com/immich-app/immich/commit/bdc6ed4124a94a5b160ec82a39d03d1374ddb5fe) fix(mobile): first char miss in new description ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/asset_viewer/ui/description_input.dart` (+8 -1) </details> ### 📄 Description Fixes #4691 #### Issue The controller's text was set to the description value from remote on each widget rebuilds. When the first character is typed, a state variable `isTextEmpty` is updated, which triggers a rebuild and thereby emptying the controller's text. This results in the first character typed by the user getting missed out. #### Change made in the PR The controller's text value is now updated only on the first build and only if the remote description is updated in the subsequent rebuilds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:22:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?