immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3918] [MERGED] chore(ml): improved logging #10162

New Issue
Closed
opened 2026-02-05 14:16:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:16:59 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3918
Author: @mertalev
Created: 8/30/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @alextran1502

Base: main ← Head: chore/ml-add-logging

📝 Commits (10+)

📊 Changes

5 files changed (+92 additions, -11 deletions)

View changed files

📝 machine-learning/app/config.py (+34 -0)
📝 machine-learning/app/main.py (+11 -2)
📝 machine-learning/app/models/base.py (+32 -4)
📝 machine-learning/app/models/clip.py (+6 -3)
📝 machine-learning/app/models/image_classification.py (+9 -2)

📄 Description

Description

Adds logging for better debugging and observability for the ML service, respecting env variables for LOG_LEVEL and NO_COLOR. This PR includes the fix from #3916.

Testing

I ran each ML job and confirmed that logs were displayed as expected, such as when a model is being downloaded and for the access logs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3918 **Author:** [@mertalev](https://github.com/mertalev) **Created:** 8/30/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `chore/ml-add-logging` --- ### 📝 Commits (10+) - [`3aa38b9`](https://github.com/immich-app/immich/commit/3aa38b9c9c222a2b1cafc2e25c048ef4cc773a2e) fixed `minScore` not being set correctly - [`106fe2d`](https://github.com/immich-app/immich/commit/106fe2dec52480d69274c699f06abe8c74a0a7b0) apply to init - [`7c3e96a`](https://github.com/immich-app/immich/commit/7c3e96a0cd52a3b7001c4321ec1ab317af64f614) don't send `enabled` - [`912b4b1`](https://github.com/immich-app/immich/commit/912b4b11cd0560ff5bcd70afcce0878f1c404c22) fix eslint warning - [`1ac776c`](https://github.com/immich-app/immich/commit/1ac776c8d4811477ef645c860062f9fa3c5e9dd5) added logger - [`ce33505`](https://github.com/immich-app/immich/commit/ce335052721ae5d98696d7b0416b480247ea5b54) added logging - [`ba14ae9`](https://github.com/immich-app/immich/commit/ba14ae94fe15768eb6ca1e2caae8c01876056d9e) refinements - [`f58ccf8`](https://github.com/immich-app/immich/commit/f58ccf8b75e46a4660d5be8f7727506a98d5d840) enable access log for info level - [`e82d139`](https://github.com/immich-app/immich/commit/e82d13961d7b38efd7a91273d9edf0e9ffbf2d4a) formatting - [`785eb85`](https://github.com/immich-app/immich/commit/785eb85a7bae0f31e86ec8758d1e03751dfdf66e) merged strings ### 📊 Changes **5 files changed** (+92 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `machine-learning/app/config.py` (+34 -0) 📝 `machine-learning/app/main.py` (+11 -2) 📝 `machine-learning/app/models/base.py` (+32 -4) 📝 `machine-learning/app/models/clip.py` (+6 -3) 📝 `machine-learning/app/models/image_classification.py` (+9 -2) </details> ### 📄 Description ## Description Adds logging for better debugging and observability for the ML service, respecting env variables for `LOG_LEVEL` and `NO_COLOR`. This PR includes the fix from #3916. ## Testing I ran each ML job and confirmed that logs were displayed as expected, such as when a model is being downloaded and for the access logs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:16:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?