[PR #32] [MERGED] Support listing and deleting users from collection #3907

New Issue

OVERLORD · 2025-10-09T18:32:24+03:00

OVERLORD commented

2025-10-09 18:32:24 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/32
Author: @mprasil
Created: 5/29/2018
Status: ✅ Merged
Merged: 5/30/2018
Merged by: @dani-garcia

Base: master ← Head: collection_users

📝 Commits (2)

62be23b Support listing and deleting users from collection
46f3b22 Removed unnecessary checks, simplified the code a bit

📊 Changes

4 files changed (+80 additions, -26 deletions)

View changed files

📝 src/api/core/mod.rs (+1 -0)
📝 src/api/core/organizations.rs (+43 -18)
📝 src/db/models/collection.rs (+20 -8)
📝 src/db/models/organization.rs (+16 -0)

📄 Description

This implements /organizations/{org_id}/collections/{coll_id}/users for #5, it also adds /organizations/<org_id>/collections/<col_id>/delete-user/<org_user_id> that is used for deleting individual users from collection.

This also improves CollectionUser::delete() to work on self rather than requesting IDs for lookup. It also returns QueryResult that is now checked. (#6)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/32 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 5/29/2018 **Status:** ✅ Merged **Merged:** 5/30/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `collection_users` --- ### 📝 Commits (2) - [`62be23b`](https://github.com/dani-garcia/vaultwarden/commit/62be23b1c01c277020eca1ec36f2d4cd4d9b881d) Support listing and deleting users from collection - [`46f3b22`](https://github.com/dani-garcia/vaultwarden/commit/46f3b229ee8dd7619d5aa493f4e885056f6f7eb3) Removed unnecessary checks, simplified the code a bit ### 📊 Changes **4 files changed** (+80 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/mod.rs` (+1 -0) 📝 `src/api/core/organizations.rs` (+43 -18) 📝 `src/db/models/collection.rs` (+20 -8) 📝 `src/db/models/organization.rs` (+16 -0) </details> ### 📄 Description This implements ` /organizations/{org_id}/collections/{coll_id}/users` for #5, it also adds `/organizations/<org_id>/collections/<col_id>/delete-user/<org_user_id>` that is used for deleting individual users from collection. This also improves `CollectionUser::delete()` to work on `self` rather than requesting IDs for lookup. It also returns `QueryResult` that is now checked. (#6) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:32:24 +03:00

OVERLORD closed this issue

2025-10-09 18:32:25 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3907