[PR #387] [MERGED] Update revision when adding or removing cipher from collection #3733

New Issue

OVERLORD · 2025-10-09T18:29:02+03:00

OVERLORD commented

2025-10-09 18:29:02 +03:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/387
Author: @mprasil
Created: 2/6/2019
Status: ✅ Merged
Merged: 2/6/2019
Merged by: @dani-garcia

Base: master ← Head: collections_edit_revision

📝 Commits (1)

08ca47c Update revision when adding or removing cipher from collection

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 src/db/models/collection.rs (+8 -0)

📄 Description

We don't update revision for affected users when adding or removing Cipher from Collection. As a result users don't see new Ciphers and still see Ciphers they should no longer have access to. This should fix that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/387 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 2/6/2019 **Status:** ✅ Merged **Merged:** 2/6/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `collections_edit_revision` --- ### 📝 Commits (1) - [`08ca47c`](https://github.com/dani-garcia/vaultwarden/commit/08ca47cadb05ac14c5e9d1cf568a2c407059190a) Update revision when adding or removing cipher from collection ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/db/models/collection.rs` (+8 -0) </details> ### 📄 Description We don't update revision for affected users when adding or removing Cipher from Collection. As a result users don't see new Ciphers and still see Ciphers they should no longer have access to. This should fix that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 18:29:02 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3733