[PR #3228] [MERGED] Fix trailing slash not getting removed from domain #3058

New Issue

Closed

opened 2025-10-09 18:16:26 +03:00 by OVERLORD · 0 comments

OVERLORD commented 2025-10-09 18:16:26 +03:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3228
Author: @BlockListed
Created: 2/7/2023
Status: ✅ Merged
Merged: 2/12/2023
Merged by: @dani-garcia

Base: main ← Head: fix-domain-description

---

📝 Commits (8)

• 64edc49 change description of domain configuration
• eb9b481 improve wording of domain description
• a72d0b5 remove documentation of bug since I'm fixing it
• 679bc7a fix trailing slash not being removed from domain
• a2aa7c9 Revert "fix trailing slash not being removed from domain"
• 5d1c11c fix trailing slash in configuration builder
• c04a135 remove warn when sanitizing domain
• af69c83 Merge branch 'main' into fix-domain-description

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/config.rs (+2 -0)

📄 Description

Bitwarden send won't work if the domain includes a trailing slash. This should be documented, as it may lead to confusion among users.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3228 **Author:** [@BlockListed](https://github.com/BlockListed) **Created:** 2/7/2023 **Status:** ✅ Merged **Merged:** 2/12/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-domain-description` --- ### 📝 Commits (8) - [`64edc49`](https://github.com/dani-garcia/vaultwarden/commit/64edc49392f1786aebf6a5a0c9b60742ca734d6e) change description of domain configuration - [`eb9b481`](https://github.com/dani-garcia/vaultwarden/commit/eb9b481eba63dbbfe0e83fac238be3482e21ccfa) improve wording of domain description - [`a72d0b5`](https://github.com/dani-garcia/vaultwarden/commit/a72d0b518fa96ba63c4029f0c60e6bd53cd92661) remove documentation of bug since I'm fixing it - [`679bc7a`](https://github.com/dani-garcia/vaultwarden/commit/679bc7a59b5daef65ef7916474577106a46fa0e9) fix trailing slash not being removed from domain - [`a2aa7c9`](https://github.com/dani-garcia/vaultwarden/commit/a2aa7c9bc23145f0f5db72f8aeed826902c86fde) Revert "fix trailing slash not being removed from domain" - [`5d1c11c`](https://github.com/dani-garcia/vaultwarden/commit/5d1c11ceba3826b5ae000d9a4d8c0ec7e094428c) fix trailing slash in configuration builder - [`c04a135`](https://github.com/dani-garcia/vaultwarden/commit/c04a1352cbc62cb55e4bb412c245c832780a20df) remove warn when sanitizing domain - [`af69c83`](https://github.com/dani-garcia/vaultwarden/commit/af69c83db2a0f362dd150dffb3ba1aab230bea64) Merge branch 'main' into fix-domain-description ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/config.rs` (+2 -0) </details> ### 📄 Description Bitwarden send won't work if the domain includes a trailing slash. This should be documented, as it may lead to confusion among users. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

OVERLORD added the pull-request label 2025-10-09 18:16:26 +03:00

OVERLORD closed this issue 2025-10-09 18:16:27 +03:00

OVERLORD referenced this issue 2025-10-09 18:17:14 +03:00

[PR #3058] [MERGED] Removed unsafe-inline JS from CSP and other fixes #3103

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

test_dylint

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

bug

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

OVERLORD

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/vaultwarden#3058