[PR #3282] [MERGED] Add confirmation for removing 2FA and deauthing sessions in admin panel #3228

Closed
opened 2026-02-05 05:19:11 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3282
Author: @JCBird1012
Created: 2/25/2023
Status: Merged
Merged: 3/1/2023
Merged by: @dani-garcia

Base: mainHead: main


📝 Commits (1)

  • 8f8d741 Add confirmation for removing 2FA and deauth sessions in admin panel

📊 Changes

1 file changed (+14 additions, -8 deletions)

View changed files

📝 src/static/scripts/admin_users.js (+14 -8)

📄 Description

As someone who has inadvertently pressed "Remove all 2FA" instead of "Deauthorize sessions" one too many times (and had to re-add all my YubiKeys) - there should be a confirmation prompt before taking either of those actions.

Regardless of my accidental misclicks - any action that modifies user state should be protected by a confirmation prompt.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3282 **Author:** [@JCBird1012](https://github.com/JCBird1012) **Created:** 2/25/2023 **Status:** ✅ Merged **Merged:** 3/1/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`8f8d741`](https://github.com/dani-garcia/vaultwarden/commit/8f8d7418eddaa180535d112f4db9da67fe8ac5b8) Add confirmation for removing 2FA and deauth sessions in admin panel ### 📊 Changes **1 file changed** (+14 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/static/scripts/admin_users.js` (+14 -8) </details> ### 📄 Description As someone who has inadvertently pressed "Remove all 2FA" instead of "Deauthorize sessions" one too many times (and had to re-add all my YubiKeys) - there should be a confirmation prompt before taking either of those actions. Regardless of my accidental misclicks - any action that modifies user state should be protected by a confirmation prompt. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 05:19:11 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/vaultwarden#3228