mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-02-24 19:07:44 +03:00
[PR #3282] [MERGED] Add confirmation for removing 2FA and deauthing sessions in admin panel #3228
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3282
Author: @JCBird1012
Created: 2/25/2023
Status: ✅ Merged
Merged: 3/1/2023
Merged by: @dani-garcia
Base:
main← Head:main📝 Commits (1)
8f8d741Add confirmation for removing 2FA and deauth sessions in admin panel📊 Changes
1 file changed (+14 additions, -8 deletions)
View changed files
📝
src/static/scripts/admin_users.js(+14 -8)📄 Description
As someone who has inadvertently pressed "Remove all 2FA" instead of "Deauthorize sessions" one too many times (and had to re-add all my YubiKeys) - there should be a confirmation prompt before taking either of those actions.
Regardless of my accidental misclicks - any action that modifies user state should be protected by a confirmation prompt.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.