[PR #296] [MERGED] feat: display groups on the user form/account page #880

New Issue

OVERLORD · 2025-10-07T00:23:59+03:00

OVERLORD commented

2025-10-07 00:23:59 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/296
Author: @kmendell
Created: 3/4/2025
Status: ✅ Merged
Merged: 3/7/2025
Merged by: @stonith404

Base: main ← Head: user-group-form

📝 Commits (9)

355dcb9 feat: display groups on the user form/account page
9f477fd fix: e2e test
114e31e fix: pagination for user groups, and add/remove group logic
8bf333b Merge branch 'main' into user-group-form
7d98f03 Merge branch 'main' into user-group-form
3c8a716 move most of the logic to the backend
0bae256 remove old user group selection
d3d4dbb add e2e test for new user group table
b8b66bb Merge branch 'main' into user-group-form

📊 Changes

14 files changed (+223 additions, -22 deletions)

View changed files

📝 backend/internal/controller/user_controller.go (+42 -0)
📝 backend/internal/controller/user_group_controller.go (+1 -1)
📝 backend/internal/dto/user_dto.go (+5 -0)
📝 backend/internal/dto/user_group_dto.go (+9 -0)
📝 backend/internal/service/ldap_service.go (+2 -6)
📝 backend/internal/service/user_group_service.go (+4 -4)
📝 backend/internal/service/user_service.go (+39 -3)
📝 frontend/src/lib/components/user-group-selection.svelte (+0 -1)
📝 frontend/src/lib/services/user-service.ts (+11 -0)
📝 frontend/src/lib/types/user.type.ts (+2 -0)
📝 frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte (+2 -2)
📝 frontend/src/routes/settings/admin/users/[id]/+page.server.ts (+4 -1)
📝 frontend/src/routes/settings/admin/users/[id]/+page.svelte (+40 -2)
📝 frontend/tests/user-settings.spec.ts (+62 -2)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/63

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/296 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 3/4/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `user-group-form` --- ### 📝 Commits (9) - [`355dcb9`](https://github.com/pocket-id/pocket-id/commit/355dcb913d2086206dbc67f3000c5098700afa09) feat: display groups on the user form/account page - [`9f477fd`](https://github.com/pocket-id/pocket-id/commit/9f477fd08d2101573a7bf4f5cfa91d03b4d5192a) fix: e2e test - [`114e31e`](https://github.com/pocket-id/pocket-id/commit/114e31e60e6ad7cf31c9e0c415b83ccd77037e32) fix: pagination for user groups, and add/remove group logic - [`8bf333b`](https://github.com/pocket-id/pocket-id/commit/8bf333b11a5cd0f0e0caec5f654b74183013cd37) Merge branch 'main' into user-group-form - [`7d98f03`](https://github.com/pocket-id/pocket-id/commit/7d98f036263e6bd8ebe6aa6bafff788786163d8e) Merge branch 'main' into user-group-form - [`3c8a716`](https://github.com/pocket-id/pocket-id/commit/3c8a716dae24ad4ced5e6971ef2587f99529caa3) move most of the logic to the backend - [`0bae256`](https://github.com/pocket-id/pocket-id/commit/0bae25685205229a341692b7056e998b49f264b4) remove old user group selection - [`d3d4dbb`](https://github.com/pocket-id/pocket-id/commit/d3d4dbbef63d2f84b6cf5be2f8ca09b0ae43f32d) add e2e test for new user group table - [`b8b66bb`](https://github.com/pocket-id/pocket-id/commit/b8b66bb5e89c68a50ec28c1a485a9d6166c6e480) Merge branch 'main' into user-group-form ### 📊 Changes **14 files changed** (+223 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/controller/user_controller.go` (+42 -0) 📝 `backend/internal/controller/user_group_controller.go` (+1 -1) 📝 `backend/internal/dto/user_dto.go` (+5 -0) 📝 `backend/internal/dto/user_group_dto.go` (+9 -0) 📝 `backend/internal/service/ldap_service.go` (+2 -6) 📝 `backend/internal/service/user_group_service.go` (+4 -4) 📝 `backend/internal/service/user_service.go` (+39 -3) 📝 `frontend/src/lib/components/user-group-selection.svelte` (+0 -1) 📝 `frontend/src/lib/services/user-service.ts` (+11 -0) 📝 `frontend/src/lib/types/user.type.ts` (+2 -0) 📝 `frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte` (+2 -2) 📝 `frontend/src/routes/settings/admin/users/[id]/+page.server.ts` (+4 -1) 📝 `frontend/src/routes/settings/admin/users/[id]/+page.svelte` (+40 -2) 📝 `frontend/tests/user-settings.spec.ts` (+62 -2) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/63 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:23:59 +03:00

OVERLORD closed this issue

2025-10-07 00:24:00 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#880