mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-06 09:13:19 +03:00
🐛 Bug Report: PocketID icon in mails is too large #296
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexlehm on GitHub.
Reproduction steps
When I look at the pocket-id mails, the P logo takes up the whole page, likely because the SVG is rendered to fit the page width
Expected behavior
The image should be maybe 100x100 pixel
Actual Behavior
Version and Environment
pocket 0.40.0
the webmail is called SnappyMail
Log Output
No response
@stonith404 commented on GitHub:
How does the rest of the mail look like?
@kmendell commented on GitHub:
the style for the header logo is set in the style_html.tmpl:
My guess is some email cleints are disreagrding these.
@alexlehm Can you try this image to see if its fixed?
ghcr.io/kmendell/pocket-id:email-icon@alexlehm commented on GitHub:
this can probably be changed by giving an explicit size for the image
in backend/resources/email-templates/login-with-new-device_html.tmpl
@paul933 commented on GitHub:
Same on Outlook app
@alexlehm commented on GitHub:
the rest looks fine
@paul933 commented on GitHub:
Fix for me in Outlook 👍
@kmendell commented on GitHub:
@stonith404 i pushed my fix to the branch
fix/email-icon, im noticing differences with the screenshots in this issue vs how mine look, my logo is aligned to the left of the header but these screenshots are not.Not sure if you wanna take a look at that part. Of if thats also a side effect of email client css rendering.
@stonith404 commented on GitHub:
The email still looks strange. It should look much better in other clients like Gmail or Apple Mail but I guess your clients just support css very limited.
@alexlehm commented on GitHub:
that looks good in my mail page