starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-29 17:25:10 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

fix: ensure file descriptors are closed + other bugs (#413)

Browse Source
This commit is contained in:
Alessandro (Ale) Segala
2025-04-04 01:04:36 -07:00
committed by GitHub
parent 980780e48b
commit 2f7646105e
6 changed files with 52 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/internal/job/file_cleanup_job.go
View File

@@ -38,9 +38,9 @@ func (j *FileCleanupJobs) clearUnusedDefaultProfilePictures() error {
}
// Create a map to track which initials are in use
initialsInUse := make(map[string]bool)
initialsInUse := make(map[string]struct{})
for _, user := range users {
initialsInUse[user.Initials()] = true
initialsInUse[user.Initials()] = struct{}{}
}
defaultPicturesDir := common.EnvConfig.UploadPath + "/profile-pictures/defaults"
@@ -63,7 +63,7 @@ func (j *FileCleanupJobs) clearUnusedDefaultProfilePictures() error {
initials := strings.TrimSuffix(filename, ".png")
// If these initials aren't used by any user, delete the file
if !initialsInUse[initials] {
if _, ok := initialsInUse[initials]; !ok {
filePath := filepath.Join(defaultPicturesDir, filename)
if err := os.Remove(filePath); err != nil {
log.Printf("Failed to delete unused default profile picture %s: %v", filePath, err)