🐛 Bug Report: create-one-time-access-token.sh doesn't work with its optional arguments #413

New Issue

OVERLORD · 2025-10-07T00:14:01+03:00

OVERLORD commented

2025-10-07 00:14:01 +03:00

Originally created by @antifuchs on GitHub.

Reproduction steps

When I invoke create-one-time-access-token.sh -d /path/to/db foo@example.com it errors saying that the username -d isn't valid.

Expected behavior

It should access the given database and create an access token for the user foo@example.com.

Actual Behavior

It sets the user identifier to the first arg on line 3, which is before optional argument processing happens; that variable should instead be set after the optional args get shifted away, on line 18.

Originally created by @antifuchs on GitHub. ### Reproduction steps When I invoke `create-one-time-access-token.sh -d /path/to/db foo@example.com` it errors saying that the username `-d` isn't valid. ### Expected behavior It should access the given database and create an access token for the user foo@example.com. ### Actual Behavior It sets the user identifier to the first arg on [line 3](https://github.com/stonith404/pocket-id/blob/main/scripts/create-one-time-access-token.sh#L3), which is before optional argument processing happens; that variable should instead be set after the optional args get shifted away, on [line 18](https://github.com/stonith404/pocket-id/blob/main/scripts/create-one-time-access-token.sh#L18).

OVERLORD added the bug label 2025-10-07 00:14:01 +03:00

OVERLORD closed this issue

2025-10-07 00:14:02 +03:00

OVERLORD commented

2025-10-07 00:14:03 +03:00

@stonith404 commented on GitHub:

Thanks, this should be fixed in v0.24.1

@stonith404 commented on GitHub: Thanks, this should be fixed in `v0.24.1`

OVERLORD referenced this issue

2025-10-07 00:22:50 +03:00

[PR #413] [MERGED] fix: ensure file descriptors are closed + other bugs #814

Sign in to join this conversation.