[PR #774] [CLOSED] feat: add PWA icon support #633

New Issue

OVERLORD · 2025-10-09T16:54:07+03:00

OVERLORD commented

2025-10-09 16:54:07 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/774
Author: @James18232
Created: 7/23/2025
Status: ❌ Closed

Base: main ← Head: feat-appleicon

📝 Commits (10+)

aa8bf5a Update +layout.svelte
cbe2ea5 Add files via upload
754564f Merge branch 'main' into feat-appleicon
0b7bb7f switch to manifest use
bf42f6e Update manifest.json.ts
0ab5ad5 Delete frontend/static/manifest.json
5304e9e serve manifest.json by prerendering server route
9db1751 remove unused imports
6034f29 Use correct webmanifest extension and content type
ff7e028 Respond with 404 when loading certain images that don't exist

📊 Changes

11 files changed (+136 additions, -12 deletions)

View changed files

📝 backend/frontend/frontend_excluded.go (+6 -2)
📝 backend/frontend/frontend_included.go (+20 -2)
📝 backend/internal/bootstrap/router_bootstrap.go (+5 -4)
📝 backend/internal/controller/app_config_controller.go (+65 -0)
➕ backend/internal/dto/web_manifest_dto.go (+14 -0)
➕ backend/resources/images/pwa-icon.png (+0 -0)
➕ backend/resources/images/pwa-icon.svg (+12 -0)
📝 frontend/src/app.html (+1 -0)
📝 frontend/src/lib/components/logo.svelte (+3 -4)
➕ frontend/src/lib/utils/logo-util.ts (+7 -0)
📝 frontend/vite.config.ts (+3 -0)

📄 Description

added apple-touch-icon support for ios devices.

used the dark logo, because it is better.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/774 **Author:** [@James18232](https://github.com/James18232) **Created:** 7/23/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat-appleicon` --- ### 📝 Commits (10+) - [`aa8bf5a`](https://github.com/pocket-id/pocket-id/commit/aa8bf5a0f9efded3c99f97b0951bba2c9ad4ed3a) Update +layout.svelte - [`cbe2ea5`](https://github.com/pocket-id/pocket-id/commit/cbe2ea555e20e65a3a62a80ae790329d2dd09cd5) Add files via upload - [`754564f`](https://github.com/pocket-id/pocket-id/commit/754564f1ccf67dee14a1309f7760178f60482c9c) Merge branch 'main' into feat-appleicon - [`0b7bb7f`](https://github.com/pocket-id/pocket-id/commit/0b7bb7f3c30785bd6e94b63950df8723087573a9) switch to manifest use - [`bf42f6e`](https://github.com/pocket-id/pocket-id/commit/bf42f6e80aa205755717b3da89795a988515e08d) Update manifest.json.ts - [`0ab5ad5`](https://github.com/pocket-id/pocket-id/commit/0ab5ad5254f26605d5da620edf4996f34d5edb8e) Delete frontend/static/manifest.json - [`5304e9e`](https://github.com/pocket-id/pocket-id/commit/5304e9e890e1003bca71cc294bf1a849e24f7028) serve manifest.json by prerendering server route - [`9db1751`](https://github.com/pocket-id/pocket-id/commit/9db1751b096aa8a1e2a1dd83ce5294d9f54a061b) remove unused imports - [`6034f29`](https://github.com/pocket-id/pocket-id/commit/6034f29505692a2bd1735cdabba02cb231392d8c) Use correct webmanifest extension and content type - [`ff7e028`](https://github.com/pocket-id/pocket-id/commit/ff7e0281be3fe06403ae547927484e214b0bea9c) Respond with 404 when loading certain images that don't exist ### 📊 Changes **11 files changed** (+136 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `backend/frontend/frontend_excluded.go` (+6 -2) 📝 `backend/frontend/frontend_included.go` (+20 -2) 📝 `backend/internal/bootstrap/router_bootstrap.go` (+5 -4) 📝 `backend/internal/controller/app_config_controller.go` (+65 -0) ➕ `backend/internal/dto/web_manifest_dto.go` (+14 -0) ➕ `backend/resources/images/pwa-icon.png` (+0 -0) ➕ `backend/resources/images/pwa-icon.svg` (+12 -0) 📝 `frontend/src/app.html` (+1 -0) 📝 `frontend/src/lib/components/logo.svelte` (+3 -4) ➕ `frontend/src/lib/utils/logo-util.ts` (+7 -0) 📝 `frontend/vite.config.ts` (+3 -0) </details> ### 📄 Description added apple-touch-icon support for ios devices. used the dark logo, because it is better. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 16:54:07 +03:00

OVERLORD closed this issue

2025-10-09 16:54:08 +03:00

OVERLORD referenced this issue

2025-10-09 16:55:36 +03:00

[PR #633] [MERGED] ci/cd: add workflow for building 'next' docker image #707

Sign in to join this conversation.