starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 22:52:58 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #490] [MERGED] Fix incorrectly swapped refreshToken and accessToken #774

New Issue
Closed
opened 2025-10-09 16:56:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:56:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/490
Author: @j-baker
Created: 4/27/2025
Status: ✅ Merged
Merged: 4/27/2025
Merged by: @kmendell

Base: main ← Head: patch-1

📝 Commits (1)

  • 58fe85f Fix incorrectly swapped refreshToken and accessToken

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/internal/controller/oidc_controller.go (+1 -1)

📄 Description

Fixes #489.

Oops. I'm not entirely sure how this would be tested because it's so high up in the stack - needs HTTP afaict. Either way, it wasn't tested so far!

Good news is that this was only broken in the last day or two I guess and probably hasn't gotten to a release!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/490 **Author:** [@j-baker](https://github.com/j-baker) **Created:** 4/27/2025 **Status:** ✅ Merged **Merged:** 4/27/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`58fe85f`](https://github.com/pocket-id/pocket-id/commit/58fe85f4b45867adae398e3db8c201f8275f4400) Fix incorrectly swapped refreshToken and accessToken ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/controller/oidc_controller.go` (+1 -1) </details> ### 📄 Description Fixes #489. Oops. I'm not entirely sure how this would be tested because it's so high up in the stack - needs HTTP afaict. Either way, it wasn't tested so far! Good news is that this was only broken in the last day or two I guess and probably hasn't gotten to a release! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:56:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#774
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?