starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 23:02:59 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #892] [MERGED] fix: update localized name and description of ldap group name attribute #565

New Issue
Closed
opened 2025-10-08 00:13:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:13:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/892
Author: @kmendell
Created: 8/27/2025
Status: ✅ Merged
Merged: 8/27/2025
Merged by: @kmendell

Base: main ← Head: fix/group-rdn-rename

📝 Commits (2)

  • c977331 fix: update localized name and description of ldap group name attribute
  • 511c9a5 fix tests

📊 Changes

3 files changed (+6 additions, -5 deletions)

View changed files

📝 frontend/messages/en.json (+3 -3)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte (+2 -1)
📝 tests/specs/ldap.spec.ts (+1 -1)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/838

This is a simple update to the localizations for the ldap Group Name Atribute, Update the descriptions to be more proper is what it actually is to hopefully alleviate some confusion, in the next breaking release we should rename the actual variable as well from ldapAttributeGroupName > ldapAttributeGroupRDN

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/892 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 8/27/2025 **Status:** ✅ Merged **Merged:** 8/27/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix/group-rdn-rename` --- ### 📝 Commits (2) - [`c977331`](https://github.com/pocket-id/pocket-id/commit/c977331130418f8ff7a6658a85caa7d44412d0dd) fix: update localized name and description of ldap group name attribute - [`511c9a5`](https://github.com/pocket-id/pocket-id/commit/511c9a5c51db4f3d188339e22ec329f832670995) fix tests ### 📊 Changes **3 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `frontend/messages/en.json` (+3 -3) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte` (+2 -1) 📝 `tests/specs/ldap.spec.ts` (+1 -1) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/838 This is a simple update to the localizations for the ldap Group Name Atribute, Update the descriptions to be more proper is what it actually is to hopefully alleviate some confusion, in the next breaking release we should rename the actual variable as well from `ldapAttributeGroupName > ldapAttributeGroupRDN` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:13:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#565
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?