starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #565] [MERGED] fix: use ldapAttributeUserUsername for finding group members #746

New Issue
Open
opened 2025-10-08 00:16:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:16:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/565
Author: @kmendell
Created: 5/25/2025
Status: ✅ Merged
Merged: 5/25/2025
Merged by: @stonith404

Base: main ← Head: fix/ad-attribute

📝 Commits (5)

  • ff2d121 fix: use ldapAttributeUserUsername for finding group members
  • 046a87d Update backend/internal/service/ldap_service.go
  • 0fa31ba Merge branch 'main' into fix/ad-attribute
  • 69d8900 fallback to better ad or ldap detection
  • 9c78cec remove unused comments

📊 Changes

1 file changed (+28 additions, -6 deletions)

View changed files

📝 backend/internal/service/ldap_service.go (+28 -6)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/553

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/565 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 5/25/2025 **Status:** ✅ Merged **Merged:** 5/25/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `fix/ad-attribute` --- ### 📝 Commits (5) - [`ff2d121`](https://github.com/pocket-id/pocket-id/commit/ff2d1216d19d80db26ac802654654a736addaa49) fix: use ldapAttributeUserUsername for finding group members - [`046a87d`](https://github.com/pocket-id/pocket-id/commit/046a87d3517612ca1f4883894b3324e97245914f) Update backend/internal/service/ldap_service.go - [`0fa31ba`](https://github.com/pocket-id/pocket-id/commit/0fa31ba7730528c18a977d6ae98dbf41c353d359) Merge branch 'main' into fix/ad-attribute - [`69d8900`](https://github.com/pocket-id/pocket-id/commit/69d89002ab4cc3bff3304ed6ed7bb3ba5522ebff) fallback to better ad or ldap detection - [`9c78cec`](https://github.com/pocket-id/pocket-id/commit/9c78cec4abaedf12d3c28e028338307cbf74ae08) remove unused comments ### 📊 Changes **1 file changed** (+28 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/ldap_service.go` (+28 -6) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/553 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:16:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?