starred/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2026-07-16 05:53:57 +03:00
Code Issues 396 Packages Projects Releases 21 Wiki Activity

[PR #1145] [MERGED] build: 🧑‍💻 specify nodemon and remove USER directive for dev container #1199

New Issue
Closed
opened 2026-02-04 21:56:30 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 21:56:30 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/1145
Author: @HannesOberreiter
Created: 5/23/2025
Status: ✅ Merged
Merged: 5/23/2025
Merged by: @meltyshev

Base: master ← Head: dev/docker

📝 Commits (3)

  • 61d4814 build: 🧑‍💻 specify nodemon and remove context from docker dev container build
  • 3308f66 fix: 🏗️ add context back as it is the default an no context does not work
  • 1a004ca build: 💚 make health check based on env

📊 Changes

3 files changed (+24 additions, -5 deletions)

View changed files

📝 Dockerfile.dev (+1 -2)
📝 docker-compose-dev.yml (+8 -3)
➕ server/nodemon.json (+15 -0)

📄 Description

  • Updated the base image in Dockerfile.dev from node:18-alpine to node:lts-alpine to use more or less the same as for production docker build (where the client is build lts and server is 18... so yeah not really...)
  • Removed the USER node directive, to prevent permission issues as we hook the whole folder into the container.
  • Modified the docker-compose-dev.yml file to enhance the database healthcheck. The new healthcheck ensures not only postgres is ready but also the database is ready by running a sample query (SELECT 1) and adjusts the interval, retries, and start period for better reliability.
  • Added a nodemon.json configuration file to watch only relevant files (node_modules would be ignored but not files like the python venv) and avoid rapid successive restarts with the delay.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/1145 **Author:** [@HannesOberreiter](https://github.com/HannesOberreiter) **Created:** 5/23/2025 **Status:** ✅ Merged **Merged:** 5/23/2025 **Merged by:** [@meltyshev](https://github.com/meltyshev) **Base:** `master` ← **Head:** `dev/docker` --- ### 📝 Commits (3) - [`61d4814`](https://github.com/plankanban/planka/commit/61d48146d31f0d3252605776ae26271241bda5b3) build: :technologist: specify nodemon and remove context from docker dev container build - [`3308f66`](https://github.com/plankanban/planka/commit/3308f66905beb4d1bc825d85cac96ffe50752a6e) fix: :building_construction: add context back as it is the default an no context does not work - [`1a004ca`](https://github.com/plankanban/planka/commit/1a004ca9b12df2ac9fce670a7ecd40f679add701) build: :green_heart: make health check based on env ### 📊 Changes **3 files changed** (+24 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile.dev` (+1 -2) 📝 `docker-compose-dev.yml` (+8 -3) ➕ `server/nodemon.json` (+15 -0) </details> ### 📄 Description * Updated the base image in `Dockerfile.dev` from `node:18-alpine` to `node:lts-alpine` to use more or less the same as for production docker build (where the client is build lts and server is 18... so yeah not really...) * Removed the `USER node` directive, to prevent permission issues as we hook the whole folder into the container. * Modified the `docker-compose-dev.yml` file to enhance the database healthcheck. The new healthcheck ensures not only postgres is ready but also the database is ready by running a sample query (`SELECT 1`) and adjusts the interval, retries, and start period for better reliability. * Added a `nodemon.json` configuration file to watch only relevant files (node_modules would be ignored but not files like the python venv) and avoid rapid successive restarts with the delay. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:56:30 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
documentation
documentation
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#1199
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?