[PR #498] [MERGED] fix(#496): Helmchart - Decoupled BASE_URL from Ingress Host #1145

Closed
opened 2025-10-09 19:09:43 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/498
Author: @rocketproto
Created: 8/23/2023
Status: Merged
Merged: 8/27/2023
Merged by: @meltyshev

Base: masterHead: custom-BASE_URL


📝 Commits (2)

📊 Changes

3 files changed (+9 additions, -2 deletions)

View changed files

📝 charts/planka/Chart.yaml (+1 -1)
📝 charts/planka/templates/deployment.yaml (+3 -1)
📝 charts/planka/values.yaml (+5 -0)

📄 Description

Fixes #496

Sets an overall baseUrl value to remove the need for an ingress to set a custom host.

Tested with baseUrl set and unset and behaving as desired. I don't have then environment to triple-check if the ingress method still works but it should.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/498 **Author:** [@rocketproto](https://github.com/rocketproto) **Created:** 8/23/2023 **Status:** ✅ Merged **Merged:** 8/27/2023 **Merged by:** [@meltyshev](https://github.com/meltyshev) **Base:** `master` ← **Head:** `custom-BASE_URL` --- ### 📝 Commits (2) - [`304b7c9`](https://github.com/plankanban/planka/commit/304b7c96ccce7d0144a94d40485a9350941338fe) fix: (#496) decoupled BASE_URL - [`19e84e0`](https://github.com/plankanban/planka/commit/19e84e0ac690136dad824094db78eb11a28eff96) chore: Update version ### 📊 Changes **3 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `charts/planka/Chart.yaml` (+1 -1) 📝 `charts/planka/templates/deployment.yaml` (+3 -1) 📝 `charts/planka/values.yaml` (+5 -0) </details> ### 📄 Description Fixes #496 Sets an overall baseUrl value to remove the need for an ingress to set a custom host. Tested with baseUrl set and unset and behaving as desired. I don't have then environment to triple-check if the ingress method still works but it should. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 19:09:43 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#1145