Commit Graph

18 Commits

Author SHA1 Message Date
GlitchWitch
c42e1fb5dd Add slack variables to docker-compose 2023-12-23 10:49:02 -06:00
Balthasar Hofer
d4b64b90fc feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2023-10-26 02:01:35 +05:00
Maksim Eltyshev
3ef5b3ead8 fix: Make default admin environment variables optional
Closes #526
2023-10-20 21:52:12 +02:00
Lorenz Brun
743f2956c8 feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
8e0c60f5be fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Maksim Eltyshev
91bc889fed feat: Use environment variables for default admin configuration 2023-09-12 01:12:38 +02:00
orbatschow
0d481703da feat: Allow postgres connections that require ssl mode (#409)
Closes #261
2023-03-06 17:54:52 +05:00
Maksim Eltyshev
3d84888eb1 revert: Allow postgres connections that require ssl mode (#408)
This reverts commit eea57ff121.
2023-02-28 02:56:16 +05:00
orbatschow
eea57ff121 feat: Allow postgres connections that require ssl mode (#404)
Closes #261
2023-02-27 21:16:51 +05:00
Maksim Eltyshev
b3323308c1 fix: Lock postgres version
Closes #312
2022-10-20 12:22:35 +02:00
Aliaksandr Shulyak
e29c9e6dda ci: GitHub actions config for docker builds (#221) 2022-04-29 17:15:59 +05:00
Maksim Eltyshev
36e4bef21b feat: Remove attachments from public access
Closes #219
2022-04-26 22:20:20 +05:00
dbrennand
729e5dac5e Make trustProxy configurable via environment variable 2021-10-21 01:24:19 +05:00
Maksim Eltyshev
99807c2a49 Fix Docker volumes 2020-05-26 01:32:11 +05:00
Maksim Eltyshev
5481ccb91f Add start script for Docker image, pre-commit lint check, package.json scripts cleanup 2020-04-24 21:44:54 +05:00
Maksim Eltyshev
f743f4ea8b Add file attachments 2020-04-21 05:44:12 +05:00
Maksim Eltyshev
64acf0ac56 Add secret key to environment variables, update readme 2019-10-04 04:19:46 +05:00
Maksim Eltyshev
d24c9a7968 Docker, update readme, update dependencies 2019-10-01 04:18:33 +05:00