starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #3940] [CLOSED] fix PGS sub burn-in on vaapi when the resolution is unspecified #9775

New Issue
Closed
opened 2026-02-07 06:08:17 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:08:17 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3940
Author: @nyanmisaka
Created: 8/20/2020
Status: ❌ Closed

Base: master ← Head: vaapi

📝 Commits (2)

  • f84255a fix sub burn-in on vaapi when the outputSize is unspecified
  • 12b36ed add bwdif filter

📊 Changes

1 file changed (+31 additions, -53 deletions)

View changed files

📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+31 -53)

📄 Description

Changes

  • drop the resolution check since outputSizeParam contains not only Size but also other hardware filters.
  • simplify related code.

Issues
vaapi and qsv will fail when burning in PGS sub if resolution is unspecified(same as input)
https://github.com/jellyfin/jellyfin/issues/3845
https://github.com/jellyfin/jellyfin/issues/2964

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3940 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 8/20/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `vaapi` --- ### 📝 Commits (2) - [`f84255a`](https://github.com/jellyfin/jellyfin/commit/f84255a8d289053f6675242a159db37ea7861d3b) fix sub burn-in on vaapi when the outputSize is unspecified - [`12b36ed`](https://github.com/jellyfin/jellyfin/commit/12b36edbda77e1de976ed1422c901728dc9da193) add bwdif filter ### 📊 Changes **1 file changed** (+31 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+31 -53) </details> ### 📄 Description **Changes** - drop the resolution check since `outputSizeParam` contains not only Size but also other hardware filters. - simplify related code. **Issues** vaapi and qsv will fail when burning in PGS sub if resolution is unspecified(same as input) https://github.com/jellyfin/jellyfin/issues/3845 https://github.com/jellyfin/jellyfin/issues/2964 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:08:17 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9775
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?