starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-03-01 03:16:51 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #3889] [MERGED] Build Unstable NuGet packages #9749

New Issue
Closed
opened 2026-02-07 06:07:48 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:07:48 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/3889
Author: @daullmer
Created: 8/13/2020
Status: ✅ Merged
Merged: 8/26/2020
Merged by: @joshuaboniface

Base: master ← Head: nuget-versioning

📝 Commits (5)

📊 Changes

7 files changed (+57 additions, -4 deletions)

View changed files

📝 .ci/azure-pipelines-package.yml (+27 -4)
📝 Emby.Naming/Emby.Naming.csproj (+1 -0)
📝 Jellyfin.Data/Jellyfin.Data.csproj (+8 -0)
📝 MediaBrowser.Common/MediaBrowser.Common.csproj (+1 -0)
📝 MediaBrowser.Controller/MediaBrowser.Controller.csproj (+1 -0)
📝 MediaBrowser.Model/MediaBrowser.Model.csproj (+1 -0)
📝 bump_version (+18 -0)

📄 Description

Changes
With this PR merged, every commit to master builds unstable nuget packages. They don't get pushed to any Nuget feeds. To achive this, I added the VersionPrefix property to every .csproj file which outputs Nuget packages and integrated the version number into the bump_version script.

I changed the Nuget pack CI task to the .Net Core pack Task because of this note in the docs

Please note that DotNetCore and DotNetStandard packages should be packaged with the DotNetCoreCLI@2 task to avoid System.InvalidCastExceptions. See the .NET Core CLI task for more details.

Issues
This allows for easier plugin development before we publish the stable version because we can make changes to the plugins during the release cycle.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/3889 **Author:** [@daullmer](https://github.com/daullmer) **Created:** 8/13/2020 **Status:** ✅ Merged **Merged:** 8/26/2020 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `nuget-versioning` --- ### 📝 Commits (5) - [`a61f6e3`](https://github.com/jellyfin/jellyfin/commit/a61f6e3308dfc9f84fe2bdfab0194b75c041d2aa) Fix nuget ci - [`f92efc7`](https://github.com/jellyfin/jellyfin/commit/f92efc7f9bf1ba74f6983102f73efb0418cb7b72) Add Publish Artifacts task - [`b92fbe4`](https://github.com/jellyfin/jellyfin/commit/b92fbe4d69975d077737042d13d4fd935bc3e3c7) Use VersionPrefix - [`2b32ebb`](https://github.com/jellyfin/jellyfin/commit/2b32ebb3ccc1ca38dd5570862b3a1a01d0d868eb) Build Unstable Nuget packages - [`bcdae0c`](https://github.com/jellyfin/jellyfin/commit/bcdae0c5a737a9be96ce0742cd1a917945d0ae9d) Use array, remove VS code line ### 📊 Changes **7 files changed** (+57 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.ci/azure-pipelines-package.yml` (+27 -4) 📝 `Emby.Naming/Emby.Naming.csproj` (+1 -0) 📝 `Jellyfin.Data/Jellyfin.Data.csproj` (+8 -0) 📝 `MediaBrowser.Common/MediaBrowser.Common.csproj` (+1 -0) 📝 `MediaBrowser.Controller/MediaBrowser.Controller.csproj` (+1 -0) 📝 `MediaBrowser.Model/MediaBrowser.Model.csproj` (+1 -0) 📝 `bump_version` (+18 -0) </details> ### 📄 Description **Changes** With this PR merged, every commit to master builds unstable nuget packages. They don't get pushed to any Nuget feeds. To achive this, I added the `VersionPrefix` property to every .csproj file which outputs Nuget packages and integrated the version number into the bump_version script. I changed the Nuget pack CI task to the .Net Core pack Task because of this note in the [docs](https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/nuget?view=azure-devops&tabs=yaml#package-versioning) > Please note that DotNetCore and DotNetStandard packages should be packaged with the DotNetCoreCLI@2 task to avoid System.InvalidCastExceptions. See the .NET Core CLI task for more details. **Issues** This allows for easier plugin development before we publish the stable version because we can make changes to the plugins during the release cycle. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:07:48 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#9749
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?