mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
Get rid of binary blobs #6
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JustAMan on GitHub (Dec 9, 2018).
I have already replaced some binary blobs with compiled from source files, but there are some more to go. We need them to be built from source with good enough license, as now they're taken from a repo with missing license, thus their legal state is unclear.
Also we'd have to fork here the repos I used via git submodules (I guess submodules still point to my personal repos).
Remove:
ThirdParty/emby/Emby.Server.Connect.dllhttps://github.com/jellyfin/jellyfin/pull/22ThirdParty/emby/Emby.Server.Sync.dllhttps://github.com/jellyfin/jellyfin/pull/22ThirdParty/emby/Emby.Server.MediaEncoding.dllhttps://github.com/jellyfin/jellyfin/pull/154, https://github.com/jellyfin/jellyfin/pull/171ThirdParty/taglib/TagLib.Portable.dllhttps://github.com/jellyfin/jellyfin/pull/41@lxp commented on GitHub (Dec 10, 2018):
It looks like with commit
dec3644c31MediaBrowser.MediaEncodingwas removed and replaced with the binary blobEmby.Server.MediaEncoding.@lxp commented on GitHub (Dec 10, 2018):
In commit
758445db59Emby.Server.Implementations.Syncwas removed and replaced with a binary blob.Same applies to
Emby.Server.Implementations.Connectwhich was removed and replaced with a binary blob in commit8c0bf13134.@joshuaboniface commented on GitHub (Dec 10, 2018):
I've moved over the submodules in #13, let me know what others we might need to create and I can add them to the org, or if we want to just leave them in the main repo that's also an option.
@JustAMan commented on GitHub (Dec 10, 2018):
Submodules seem to be correct. Now we probably need to replace remaining blobs with earlier commits as found by @lxp. I was not able to find a repo with defined license. Source for remaining blobs was, if I'm not mistaken, in Emby.Common, but that repo did not have any license at all, so I decided not to fork it.
@joshuaboniface commented on GitHub (Dec 10, 2018):
Hopefully it isn't too hard to revert those files back to their non-blob versions from whats in this repo, but I haven't dug into it yet.
@andrewrabert commented on GitHub (Dec 11, 2018):
Only
Emby.Server.MediaEncoding.dllremains from the Emby-specific blobs.@emmatyping commented on GitHub (Dec 11, 2018):
It appears that
Taglib.Portableis just https://github.com/timheuer/taglib-sharp-portable which is LGPL 2.1, so it should be very easy to remove that "blob".@andrewrabert commented on GitHub (Dec 13, 2018):
Working on removing
Emby.Server.MediaEncodingat https://github.com/nvllsvm/jellyfin/tree/encoding@andrewrabert commented on GitHub (Dec 15, 2018):
@MatMaul has removed the final Emby blob!
@andrewrabert commented on GitHub (Dec 15, 2018):
Playback state was was broken when
Emby.Server.MediaEncodingwas removed. Reimplemented with https://github.com/jellyfin/jellyfin/pull/171@bobberb commented on GitHub (Dec 17, 2018):
Congratulations to a return to open source software as of 2 days ago @nvllsvm ?
@andrewrabert commented on GitHub (Dec 17, 2018):
@bobberb - yup, it's blob free now! Albeit subtitle loading is much slower than before https://github.com/jellyfin/jellyfin/issues/172