starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #14094] [MERGED] Translate query by AncestorIds correctly #13835

New Issue
Closed
opened 2026-02-07 07:19:55 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:19:55 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14094
Author: @allesmi
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/15/2025
Merged by: @Bond-009

Base: master ← Head: fix/ancestor-ids-parent-child-relation

📝 Commits (4)

  • 50f2be2 fix: fix parent child relation in AncestorIds
  • 91284f7 fix: remove empty migration
  • 8e877a8 Fix at query level
  • e75e036 Add allesmi to CONTRIBUTORS.md

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+1 -1)

📄 Description

PR #13827 added a regression in the parent/child relation modelled in the table AncestorIds. This broke some features, e.g. the automatic creation of collection for movies.

Changes

This PR changes the translation of the filter by AncestorIds. It now queries for BaseItems, that have a parent in AncestorIds (used to be BaseItems who have a child item with AncestorIds).

Issues

Fixes: https://github.com/jellyfin/jellyfin/issues/13876
Fixes: https://github.com/jellyfin/jellyfin/issues/13882
Fixes: https://github.com/jellyfin/jellyfin/issues/13936
Fixes: https://github.com/jellyfin/jellyfin/issues/14091

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14094 **Author:** [@allesmi](https://github.com/allesmi) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/15/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix/ancestor-ids-parent-child-relation` --- ### 📝 Commits (4) - [`50f2be2`](https://github.com/jellyfin/jellyfin/commit/50f2be251a665508e116120d027495595941e865) fix: fix parent child relation in AncestorIds - [`91284f7`](https://github.com/jellyfin/jellyfin/commit/91284f74fed9e39c7056cda356d9e2ca17d0faa2) fix: remove empty migration - [`8e877a8`](https://github.com/jellyfin/jellyfin/commit/8e877a8798d3214147a76e6c5b4858827d67cba0) Fix at query level - [`e75e036`](https://github.com/jellyfin/jellyfin/commit/e75e03623195102bce4f6218c6880e5e0066c21c) Add allesmi to CONTRIBUTORS.md ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+1 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> PR #13827 added a regression in the parent/child relation modelled in the table `AncestorIds`. This broke some features, e.g. the automatic creation of collection for movies. **Changes** This PR changes the translation of the filter by AncestorIds. It now queries for BaseItems, that have a parent in AncestorIds (used to be BaseItems who have a child item with AncestorIds). **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes: https://github.com/jellyfin/jellyfin/issues/13876 Fixes: https://github.com/jellyfin/jellyfin/issues/13882 Fixes: https://github.com/jellyfin/jellyfin/issues/13936 Fixes: https://github.com/jellyfin/jellyfin/issues/14091 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:19:55 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?