starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #14082] [MERGED] Reject invalid replaygain tag value #13827

New Issue
Closed
opened 2026-02-07 07:19:51 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:19:51 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14082
Author: @gnattu
Created: 5/8/2025
Status: ✅ Merged
Merged: 5/9/2025
Merged by: @crobibero

Base: master ← Head: reject-invalid-gain-value

📝 Commits (1)

  • 9aec9c0 Reject invalid replaygain tag value

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+1 -1)

📄 Description

In .NET, float.TryParse("NaN", NumberStyles.Float, CultureInfo.InvariantCulture, out var value) returns true and value will be float.NaN.

Only accept finite values for replaygain tag.

Changes

Issues

Fixes #13290

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14082 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 5/8/2025 **Status:** ✅ Merged **Merged:** 5/9/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `reject-invalid-gain-value` --- ### 📝 Commits (1) - [`9aec9c0`](https://github.com/jellyfin/jellyfin/commit/9aec9c0584c17a828b9d01dca230fc20d44cf1b0) Reject invalid replaygain tag value ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+1 -1) </details> ### 📄 Description In .NET, `float.TryParse("NaN", NumberStyles.Float, CultureInfo.InvariantCulture, out var value)` returns `true` and value will be `float.NaN`. Only accept finite values for replaygain tag. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #13290 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:19:51 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13827
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?