mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #13475] [CLOSED] Fix transcoding if audio is unsupported #13591
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/13475
Author: @ACertainCoder
Created: 2/2/2025
Status: ❌ Closed
Base:
master← Head:fix/audio-transcoding📝 Commits (2)
c3b0632Fix transcoding if audio is unsupportedfc679baRemove negation📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
MediaBrowser.Model/Dlna/StreamBuilder.cs(+1 -1)📄 Description
Changes
When using DLNA to play a video on another device that doesn't support the audio stream of that video, Jellyfin doesn't transcode it (typical log message:
PlayMethod=DirectStream, TranscodeReason=ContainerNotSupported, AudioCodecNotSupported). The line responsible for filtering direct stream issues excludes these reasons rather than making them exclusive.Changing the negated bitwise-anding to a regular one fixes this problem. I could verify that the correct audio stream was then provided to my DLNA renderer and that playback via Jellyfin web was still functioning as expected (without the need for transcoding).
Issues
https://github.com/jellyfin/jellyfin-plugin-dlna/issues/23
Please correct me if this change would have unwanted consequences.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.