starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #13125] [CLOSED] Migrate keyframes to configured cache directory #13475

New Issue
Closed
opened 2026-02-07 07:13:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:13:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13125
Author: @tcely
Created: 11/29/2024
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (5)

  • 8653943 Migrate keyframes to configured cache directory
  • 25b4cb2 Fixes from PR checks
  • d14ea89 Read newly cached json then fall back to the old json
  • 1504a0c Fixed whitespace reported by PR checks
  • f64ed6f Avoid cleanup for referenced keyframes files

📊 Changes

1 file changed (+17 additions, -1 deletions)

View changed files

📝 src/Jellyfin.MediaEncoding.Hls/Cache/CacheDecorator.cs (+17 -1)

📄 Description

I'm not sure why these were put into the data directory in the first place.

The TODO comment about making it configurable is satisfied, for me, by using the already configurable cache directory instead.

Changes

Check for old keyframes json files in the data directory.
Only write new files to the cache directory.

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13125 **Author:** [@tcely](https://github.com/tcely) **Created:** 11/29/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (5) - [`8653943`](https://github.com/jellyfin/jellyfin/commit/8653943fac875ff0a5ed650561fa879e2183d6ee) Migrate keyframes to configured cache directory - [`25b4cb2`](https://github.com/jellyfin/jellyfin/commit/25b4cb2a339344c9759dcaf7b8f348b8728cb849) Fixes from PR checks - [`d14ea89`](https://github.com/jellyfin/jellyfin/commit/d14ea89829097a3053e1100f7e780553fe179693) Read newly cached json then fall back to the old json - [`1504a0c`](https://github.com/jellyfin/jellyfin/commit/1504a0ca4f9120f3ddeb95207cbac09e27b638ce) Fixed whitespace reported by PR checks - [`f64ed6f`](https://github.com/jellyfin/jellyfin/commit/f64ed6f7517608e28eb18f64f21a1000373d24a1) Avoid cleanup for referenced keyframes files ### 📊 Changes **1 file changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Jellyfin.MediaEncoding.Hls/Cache/CacheDecorator.cs` (+17 -1) </details> ### 📄 Description I'm not sure why these were put into the data directory in the first place. The TODO comment about making it configurable is satisfied, for me, by using the already configurable cache directory instead. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Check for old keyframes json files in the data directory. Only write new files to the cache directory. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:13:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?