[PR #13182] [MERGED] Don't fall back to ffprobe results for multi-value audio tags #13495

Closed
opened 2026-02-07 07:13:54 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13182
Author: @gnattu
Created: 12/8/2024
Status: Merged
Merged: 12/21/2024
Merged by: @Bond-009

Base: release-10.10.zHead: no-multivalue-ffprobe-fallback


📝 Commits (1)

  • d49bb1d Don't fall back to ffprobe results for multi-value audio tags

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+3 -3)

📄 Description

Changes

The intention behind using ffprobe as a fallback for the ATL library was to obtain information when ATL failed due to errors, hoping that ffprobe would be more robust. However, for multi-value tags, the old ffprobe normalizer still incorporates a lot of Emby-era logic. Such logic includes multi-level fallbacks and splits tags using delimiters that are not user-customizable. For instance, the normalizer might prefer the ARTISTS tag even if the user has disabled it in the library settings, or use delimiters that the user has excluded. If ATL fails to retrieve any data for those multi-value fields, the tag should be considered empty to avoid wrong data be filled.

Issues

Fixes #12981


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13182 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 12/8/2024 **Status:** ✅ Merged **Merged:** 12/21/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `release-10.10.z` ← **Head:** `no-multivalue-ffprobe-fallback` --- ### 📝 Commits (1) - [`d49bb1d`](https://github.com/jellyfin/jellyfin/commit/d49bb1d86da60fd9dc658f7554fc1aaa958f9c71) Don't fall back to ffprobe results for multi-value audio tags ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+3 -3) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> The intention behind using ffprobe as a fallback for the ATL library was to obtain information when ATL failed due to errors, hoping that ffprobe would be more robust. However, for multi-value tags, the old ffprobe normalizer still incorporates a lot of Emby-era logic. Such logic includes multi-level fallbacks and splits tags using delimiters that are not user-customizable. For instance, the normalizer might prefer the ARTISTS tag even if the user has disabled it in the library settings, or use delimiters that the user has excluded. If ATL fails to retrieve any data for those multi-value fields, the tag should be considered empty to avoid wrong data be filled. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #12981 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:13:54 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13495