mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[PR #13182] [MERGED] Don't fall back to ffprobe results for multi-value audio tags #13495
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/13182
Author: @gnattu
Created: 12/8/2024
Status: ✅ Merged
Merged: 12/21/2024
Merged by: @Bond-009
Base:
release-10.10.z← Head:no-multivalue-ffprobe-fallback📝 Commits (1)
d49bb1dDon't fall back to ffprobe results for multi-value audio tags📊 Changes
1 file changed (+3 additions, -3 deletions)
View changed files
📝
MediaBrowser.Providers/MediaInfo/AudioFileProber.cs(+3 -3)📄 Description
Changes
The intention behind using ffprobe as a fallback for the ATL library was to obtain information when ATL failed due to errors, hoping that ffprobe would be more robust. However, for multi-value tags, the old ffprobe normalizer still incorporates a lot of Emby-era logic. Such logic includes multi-level fallbacks and splits tags using delimiters that are not user-customizable. For instance, the normalizer might prefer the ARTISTS tag even if the user has disabled it in the library settings, or use delimiters that the user has excluded. If ATL fails to retrieve any data for those multi-value fields, the tag should be considered empty to avoid wrong data be filled.
Issues
Fixes #12981
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.