starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #12414] [MERGED] Revert "NextUp query respects Limit (#11956)" #13182

New Issue
Closed
opened 2026-02-07 07:08:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:08:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12414
Author: @fredrik-eriksson
Created: 8/9/2024
Status: ✅ Merged
Merged: 8/23/2024
Merged by: @crobibero

Base: release-10.9.z ← Head: nextupfix-10.9.z

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Emby.Server.Implementations/TV/TVSeriesManager.cs (+1 -1)

📄 Description

This reverts commit 484aea1cdb.

Turns out this fix from PR #11956 leads to unexpected behaviour as described in issue #12367.

Fixes: #12367

Changes

Setting the limit here limits how many series is considered watching; not how many items to return to the client. For a proper fix of the original performance issue I think either the query needs to be redesigned or the post-processing of the result from this query needs to be smarter somehow...

Note that this PR is against 10.9.z (as that was where the original PR was), but it looks like the original commit was backported to master as well, so it should probably be reverted there as well.

Issues

Fixes #12367
Possibly re-opens #11888 #11316

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12414 **Author:** [@fredrik-eriksson](https://github.com/fredrik-eriksson) **Created:** 8/9/2024 **Status:** ✅ Merged **Merged:** 8/23/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.9.z` ← **Head:** `nextupfix-10.9.z` --- ### 📝 Commits (1) - [`5633146`](https://github.com/jellyfin/jellyfin/commit/56331463d520686d51b65b6d64d7d054e52e18c0) Revert "NextUp query respects Limit (#11956)" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/TV/TVSeriesManager.cs` (+1 -1) </details> ### 📄 Description This reverts commit 484aea1cdb93804b8388cdf3dfa3344942ad9119. Turns out this fix from PR #11956 leads to unexpected behaviour as described in issue #12367. Fixes: #12367 <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Setting the limit here limits how many series is considered watching; not how many items to return to the client. For a proper fix of the original performance issue I think either the query needs to be redesigned or the [post-processing](https://github.com/jellyfin/jellyfin/blob/d4eeafe53ff8ae2f287f5dca49a873cd71f4c3da/Emby.Server.Implementations/TV/TVSeriesManager.cs#L187C79-L187C88) of the result from this query needs to be smarter somehow... Note that this PR is against 10.9.z (as that was where the original PR was), but it looks like the original commit was backported to master as well, so it should probably be reverted there as well. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #12367 Possibly re-opens #11888 #11316 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:08:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?