starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #10499] fix regression in subtitle provider instantiation #12510

New Issue
Closed
opened 2026-02-07 06:57:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:57:10 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/10499

State: closed
Merged: No

Fix subtitle provider instantiation (regression).

Changes
Rolled back some changes made from 10.8 to 10.9 in order to have the opensubtitle provider working.

Issues
While working on this feature, i came across the following error when trying to use the opensubtitle plugin with jellyfin 10.9:

[22:33:27] [ERR] [18] Jellyfin.Api.Middleware.ExceptionMiddleware: Error processing request. URL POST /Jellyfin.Plugin.OpenSubtitles/ValidateLoginInfo.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Jellyfin.Plugin.OpenSubtitles.OpenSubtitlesHandler.RequestHandler.SendRequestAsync(String endpoint, HttpMethod method, Object body, Dictionary`2 headers, String apiKey, Int32 attempt, CancellationToken cancellationToken)

After investigating, I found out that the _subtitleProviders list from the subtitleManager was empty. This PR fixes the instantiation problem.

PR linked
https://github.com/jellyfin/jellyfin/pull/10410
https://github.com/jellyfin/jellyfin-web/pull/4883

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/10499 **State:** closed **Merged:** No --- Fix subtitle provider instantiation (regression). **Changes** Rolled back some changes made from 10.8 to 10.9 in order to have the opensubtitle provider working. **Issues** While working on [this feature](https://features.jellyfin.org/posts/185/non-admin-users-download-subtitles), i came across the following error when trying to use the opensubtitle plugin with jellyfin 10.9: ```log [22:33:27] [ERR] [18] Jellyfin.Api.Middleware.ExceptionMiddleware: Error processing request. URL POST /Jellyfin.Plugin.OpenSubtitles/ValidateLoginInfo. System.NullReferenceException: Object reference not set to an instance of an object. at Jellyfin.Plugin.OpenSubtitles.OpenSubtitlesHandler.RequestHandler.SendRequestAsync(String endpoint, HttpMethod method, Object body, Dictionary`2 headers, String apiKey, Int32 attempt, CancellationToken cancellationToken) ``` After investigating, I found out that the _subtitleProviders list from the subtitleManager was empty. This PR fixes the instantiation problem. **PR linked** https://github.com/jellyfin/jellyfin/pull/10410 https://github.com/jellyfin/jellyfin-web/pull/4883
OVERLORD added the pull-request label 2026-02-07 06:57:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12510
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?