starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #5366] [MERGED] Reduce Skia conversions #10499

New Issue
Closed
opened 2026-02-07 06:21:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:21:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5366
Author: @ferferga
Created: 3/4/2021
Status: ✅ Merged
Merged: 4/1/2025
Merged by: @crobibero

Base: master ← Head: skia-improvement

📝 Commits (1)

  • 4968713 Reduce SKImage to SKBitmap conversion, high quality canvas

📊 Changes

2 files changed (+19 additions, -19 deletions)

View changed files

📝 src/Jellyfin.Drawing.Skia/SkiaEncoder.cs (+7 -13)
📝 src/Jellyfin.Drawing.Skia/StripCollageBuilder.cs (+12 -6)

📄 Description

Includes the warnings fixes from #5360

  • The resizing process involved multiple SKImage to SKBitmap conversions. Reduced those conversions and using the native methods that Skia provides for drawing each Canvas
  • Use High quality filter on all the canvas.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5366 **Author:** [@ferferga](https://github.com/ferferga) **Created:** 3/4/2021 **Status:** ✅ Merged **Merged:** 4/1/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `skia-improvement` --- ### 📝 Commits (1) - [`4968713`](https://github.com/jellyfin/jellyfin/commit/49687130b684914a6ca7d546760d79f802420d33) Reduce SKImage to SKBitmap conversion, high quality canvas ### 📊 Changes **2 files changed** (+19 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/Jellyfin.Drawing.Skia/SkiaEncoder.cs` (+7 -13) 📝 `src/Jellyfin.Drawing.Skia/StripCollageBuilder.cs` (+12 -6) </details> ### 📄 Description Includes the warnings fixes from #5360 * The resizing process involved multiple SKImage to SKBitmap conversions. Reduced those conversions and using the native methods that Skia provides for drawing each Canvas * Use High quality filter on all the canvas. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:21:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10499
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?