starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #7611] Refactor GetDownload into LibraryManager. #11474

New Issue
Closed
opened 2026-02-07 06:39:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:39:08 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/7611

State: closed
Merged: No

Changes
Refactored GetDownload from LibraryController to LibraryManager.

This addresses #3122 where the LibraryController contained a direct reference to ActivityLog EF model class. Instead of creating a DTO class and refactoring ActivityManager to use a DTO, the logic was pulled into the service layer. The service layer now uses EventManager to publish ItemDownloadEventArgs to a newly created IEventConsumer, which will then create the ActivityLog records. The made the most sense since all other references to ActivityLog were also IEventConsumer logger-types.

Issues

Addresses #3122

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/7611 **State:** closed **Merged:** No --- <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Refactored `GetDownload` from `LibraryController` to `LibraryManager`. This addresses #3122 where the `LibraryController` contained a direct reference to `ActivityLog` EF model class. Instead of creating a DTO class and refactoring `ActivityManager` to use a DTO, the logic was pulled into the service layer. The service layer now uses `EventManager` to publish `ItemDownloadEventArgs` to a newly created `IEventConsumer`, which will then create the `ActivityLog` records. The made the most sense since all other references to `ActivityLog` were also `IEventConsumer` logger-types. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Addresses #3122
OVERLORD added the pull-request label 2026-02-07 06:39:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11474
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?