[PR #6453] [CLOSED] Simplify logic in MediaSourceInfo #10970

Closed
opened 2026-02-07 06:30:03 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6453
Author: @GodTamIt
Created: 8/19/2021
Status: Closed

Base: masterHead: simplify-mediasourceinfo


📝 Commits (1)

  • 1326268 Simplify logic in MediaSourceInfo

📊 Changes

5 files changed (+80 additions, -126 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 Jellyfin.Api/Helpers/MediaInfoHelper.cs (+2 -2)
📝 MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs (+2 -2)
📝 MediaBrowser.Model/Dto/MediaSourceInfo.cs (+51 -98)
📝 tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeResultNormalizerTests.cs (+24 -24)

📄 Description

Changes
This change cleans up the logic inside MediaSourceInfo.cs. As part of the change, the file will no longer have to disable the nullable context.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6453 **Author:** [@GodTamIt](https://github.com/GodTamIt) **Created:** 8/19/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `simplify-mediasourceinfo` --- ### 📝 Commits (1) - [`1326268`](https://github.com/jellyfin/jellyfin/commit/1326268a7eaf2ceafcc8f1147cbcf0a438647423) Simplify logic in MediaSourceInfo ### 📊 Changes **5 files changed** (+80 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `Jellyfin.Api/Helpers/MediaInfoHelper.cs` (+2 -2) 📝 `MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs` (+2 -2) 📝 `MediaBrowser.Model/Dto/MediaSourceInfo.cs` (+51 -98) 📝 `tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeResultNormalizerTests.cs` (+24 -24) </details> ### 📄 Description **Changes** This change cleans up the logic inside `MediaSourceInfo.cs`. As part of the change, the file will no longer have to disable the nullable context. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:30:03 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10970