starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4875] [CLOSED] Networking: Clean up remaining Emby.Dlna code post DLNA extraction. #10314

New Issue
Closed
opened 2026-02-07 06:18:01 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:18:01 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4875
Author: @BaronGreenback
Created: 12/28/2020
Status: ❌ Closed

Base: master ← Head: DLNAProfile

📝 Commits (9)

📊 Changes

77 files changed (+4757 additions, -8990 deletions)

View changed files

📝 Emby.Dlna/ConnectionManager/ControlHandler.cs (+1 -1)
📝 Emby.Dlna/Didl/DidlBuilder.cs (+4 -15)
📝 Emby.Dlna/DlnaManager.cs (+331 -301)
📝 Emby.Dlna/PlayTo/DeviceInfo.cs (+1 -2)
📝 Emby.Dlna/PlayTo/PlayToController.cs (+13 -22)
📝 Emby.Dlna/PlayTo/PlayToManager.cs (+1 -1)
📝 Emby.Dlna/PlayTo/PlaylistItemFactory.cs (+5 -8)
📝 Emby.Dlna/Profiles/DefaultProfile.cs (+30 -109)
➖ Emby.Dlna/Profiles/DenonAvrProfile.cs (+0 -34)
➖ Emby.Dlna/Profiles/DirectTvProfile.cs (+0 -129)
➖ Emby.Dlna/Profiles/DishHopperJoeyProfile.cs (+0 -228)
➖ Emby.Dlna/Profiles/Foobar2000Profile.cs (+0 -78)
➖ Emby.Dlna/Profiles/LgTvProfile.cs (+0 -211)
➖ Emby.Dlna/Profiles/LinksysDMA2100Profile.cs (+0 -55)
➖ Emby.Dlna/Profiles/MarantzProfile.cs (+0 -43)
➖ Emby.Dlna/Profiles/MediaMonkeyProfile.cs (+0 -44)
➖ Emby.Dlna/Profiles/PanasonicVieraProfile.cs (+0 -222)
➖ Emby.Dlna/Profiles/PopcornHourProfile.cs (+0 -225)
➖ Emby.Dlna/Profiles/SamsungSmartTvProfile.cs (+0 -367)
➖ Emby.Dlna/Profiles/SharpSmartTvProfile.cs (+0 -121)

...and 57 more files

📄 Description

Sorry for the size - 30 odd files are the dlna profiles being moved out.

This removes the warnings and messages from the DLNA profile code that is all that remains after the DLNA sub-system has been moved into the plugins. (#4619)

Restricted changes to MediaBrowser.Model\DLNA with a couple of minor changes elsewhere due to nullability changes.
Files moved out are from Emby.Dlna\Profiles\

Changes
Commented all public methods and classes.
Re-ordering of methods as recommended by VC.
Code optimization as recommended by VC.
Removed unused parameters as recommended by VC.
Nullable enabled with specific awareness given to serialization.
Tested structures by rebuilding the system xml profiles and comparing with current ones.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4875 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 12/28/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `DLNAProfile` --- ### 📝 Commits (9) - [`4b286c5`](https://github.com/jellyfin/jellyfin/commit/4b286c50d9274b527a64532a303177991067da85) Initial upload - [`1f33e6f`](https://github.com/jellyfin/jellyfin/commit/1f33e6fe99799470a26a31320e3efa7256ab8fdc) Removing test unit - [`85dd302`](https://github.com/jellyfin/jellyfin/commit/85dd30213f3e00f3654a7f930ee8b267bdb62549) rollback a space. - [`39f126d`](https://github.com/jellyfin/jellyfin/commit/39f126dd7abd8c27614f9cff746fdb37dcda2324) Nullable xmlattribute - [`17328bc`](https://github.com/jellyfin/jellyfin/commit/17328bc415a346e6202b0c04a788278394438f71) Merge branch 'master' into DLNAProfile - [`5cb96a2`](https://github.com/jellyfin/jellyfin/commit/5cb96a2ba06cc7f36832332216dc057a20c7c6f8) Fixed merge - [`4221169`](https://github.com/jellyfin/jellyfin/commit/42211693daa4535d4e03a577a2af5dd626191e7e) commented - [`0648271`](https://github.com/jellyfin/jellyfin/commit/0648271027e25a483e3fa974465370311dbb0c45) Fixed build - [`3a6e010`](https://github.com/jellyfin/jellyfin/commit/3a6e010bdd0cb298b665a92eaf76c08400de3eb5) Merge branch 'master' into DLNAProfile ### 📊 Changes **77 files changed** (+4757 additions, -8990 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/ConnectionManager/ControlHandler.cs` (+1 -1) 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+4 -15) 📝 `Emby.Dlna/DlnaManager.cs` (+331 -301) 📝 `Emby.Dlna/PlayTo/DeviceInfo.cs` (+1 -2) 📝 `Emby.Dlna/PlayTo/PlayToController.cs` (+13 -22) 📝 `Emby.Dlna/PlayTo/PlayToManager.cs` (+1 -1) 📝 `Emby.Dlna/PlayTo/PlaylistItemFactory.cs` (+5 -8) 📝 `Emby.Dlna/Profiles/DefaultProfile.cs` (+30 -109) ➖ `Emby.Dlna/Profiles/DenonAvrProfile.cs` (+0 -34) ➖ `Emby.Dlna/Profiles/DirectTvProfile.cs` (+0 -129) ➖ `Emby.Dlna/Profiles/DishHopperJoeyProfile.cs` (+0 -228) ➖ `Emby.Dlna/Profiles/Foobar2000Profile.cs` (+0 -78) ➖ `Emby.Dlna/Profiles/LgTvProfile.cs` (+0 -211) ➖ `Emby.Dlna/Profiles/LinksysDMA2100Profile.cs` (+0 -55) ➖ `Emby.Dlna/Profiles/MarantzProfile.cs` (+0 -43) ➖ `Emby.Dlna/Profiles/MediaMonkeyProfile.cs` (+0 -44) ➖ `Emby.Dlna/Profiles/PanasonicVieraProfile.cs` (+0 -222) ➖ `Emby.Dlna/Profiles/PopcornHourProfile.cs` (+0 -225) ➖ `Emby.Dlna/Profiles/SamsungSmartTvProfile.cs` (+0 -367) ➖ `Emby.Dlna/Profiles/SharpSmartTvProfile.cs` (+0 -121) _...and 57 more files_ </details> ### 📄 Description Sorry for the size - 30 odd files are the dlna profiles being moved out. This removes the warnings and messages from the DLNA profile code that is all that remains after the DLNA sub-system has been moved into the plugins. (#4619) Restricted changes to _MediaBrowser.Model\DLNA_ with a couple of minor changes elsewhere due to nullability changes. Files moved out are from Emby.Dlna\Profiles\ **Changes** Commented all public methods and classes. Re-ordering of methods as recommended by VC. Code optimization as recommended by VC. Removed unused parameters as recommended by VC. Nullable enabled with specific awareness given to serialization. Tested structures by rebuilding the system xml profiles and comparing with current ones. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:18:01 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10314
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?