starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #4619] [CLOSED] Networking PR 5: Removal of DLNA and UPnP #10193

New Issue
Closed
opened 2026-02-07 06:15:44 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:15:44 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4619
Author: @BaronGreenback
Created: 11/30/2020
Status: ❌ Closed

Base: master ← Head: NetworkPhase2Final

📝 Commits (10+)

📊 Changes

218 files changed (+6577 additions, -24560 deletions)

View changed files

➖ Emby.Dlna/Common/Argument.cs (+0 -23)
➖ Emby.Dlna/Common/DeviceIcon.cs (+0 -41)
➖ Emby.Dlna/Common/DeviceService.cs (+0 -36)
➖ Emby.Dlna/Common/ServiceAction.cs (+0 -31)
➖ Emby.Dlna/Common/StateVariable.cs (+0 -34)
➖ Emby.Dlna/Configuration/DlnaOptions.cs (+0 -92)
➖ Emby.Dlna/ConfigurationExtension.cs (+0 -16)
➖ Emby.Dlna/ConnectionManager/ConnectionManagerService.cs (+0 -53)
➖ Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs (+0 -121)
➖ Emby.Dlna/ConnectionManager/ControlHandler.cs (+0 -55)
➖ Emby.Dlna/ConnectionManager/ServiceActionListBuilder.cs (+0 -234)
➖ Emby.Dlna/ContentDirectory/ContentDirectoryService.cs (+0 -176)
➖ Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs (+0 -161)
➖ Emby.Dlna/ContentDirectory/ControlHandler.cs (+0 -1735)
➖ Emby.Dlna/ContentDirectory/ServerItem.cs (+0 -36)
➖ Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs (+0 -415)
➖ Emby.Dlna/ContentDirectory/StubType.cs (+0 -31)
➖ Emby.Dlna/ControlRequest.cs (+0 -23)
➖ Emby.Dlna/ControlResponse.cs (+0 -26)
➖ Emby.Dlna/Didl/DidlBuilder.cs (+0 -1248)

...and 80 more files

📄 Description

Cumulative Change

DLNA Server, DNLA PlayTo and UPnP (Automatic Port Mapping) have been removed and can be found as plugins at https://github.com/BaronGreenback (at the moment).

This is a cumulative change, so the files that are changed will reduce as the subsequent network PR's are accepted.

Known issues
The dashboard errors when DLNA is select.

Breaking change
startupRemoteAccessDto.EnableAutomaticPortMapping is no longer supported as UPnP has been moved to a plugin.

Depends on
PR1: Reduction in code nesting - #4587
PR2: Move AddressOverrideKey into StartupOptions.cs - #4571
PR3: UDP Code - #4543
PR4: Clean up DLNA profiles - #4875

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4619 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 11/30/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `NetworkPhase2Final` --- ### 📝 Commits (10+) - [`459651b`](https://github.com/jellyfin/jellyfin/commit/459651b14fee781f40a623cec38860e0b468816a) initial upload - [`5ef7412`](https://github.com/jellyfin/jellyfin/commit/5ef7412c32f7437f86f911e7b6395e1e2e74a259) Updated to master - [`4b286c5`](https://github.com/jellyfin/jellyfin/commit/4b286c50d9274b527a64532a303177991067da85) Initial upload - [`1f33e6f`](https://github.com/jellyfin/jellyfin/commit/1f33e6fe99799470a26a31320e3efa7256ab8fdc) Removing test unit - [`85dd302`](https://github.com/jellyfin/jellyfin/commit/85dd30213f3e00f3654a7f930ee8b267bdb62549) rollback a space. - [`39f126d`](https://github.com/jellyfin/jellyfin/commit/39f126dd7abd8c27614f9cff746fdb37dcda2324) Nullable xmlattribute - [`229fc75`](https://github.com/jellyfin/jellyfin/commit/229fc752aa2faeb3a2984a69159e62f1fc07c171) Initial upload - [`9845500`](https://github.com/jellyfin/jellyfin/commit/9845500151d3886fb934d1c6104095f5292b1cf9) fix. - [`71f9352`](https://github.com/jellyfin/jellyfin/commit/71f93521a5a4fa05369ebdd24107ee0253b462bd) debugging - [`314754a`](https://github.com/jellyfin/jellyfin/commit/314754a99b11ca25292f4b3eba1dcb5adeecc084) Updated with #4875 ### 📊 Changes **218 files changed** (+6577 additions, -24560 deletions) <details> <summary>View changed files</summary> ➖ `Emby.Dlna/Common/Argument.cs` (+0 -23) ➖ `Emby.Dlna/Common/DeviceIcon.cs` (+0 -41) ➖ `Emby.Dlna/Common/DeviceService.cs` (+0 -36) ➖ `Emby.Dlna/Common/ServiceAction.cs` (+0 -31) ➖ `Emby.Dlna/Common/StateVariable.cs` (+0 -34) ➖ `Emby.Dlna/Configuration/DlnaOptions.cs` (+0 -92) ➖ `Emby.Dlna/ConfigurationExtension.cs` (+0 -16) ➖ `Emby.Dlna/ConnectionManager/ConnectionManagerService.cs` (+0 -53) ➖ `Emby.Dlna/ConnectionManager/ConnectionManagerXmlBuilder.cs` (+0 -121) ➖ `Emby.Dlna/ConnectionManager/ControlHandler.cs` (+0 -55) ➖ `Emby.Dlna/ConnectionManager/ServiceActionListBuilder.cs` (+0 -234) ➖ `Emby.Dlna/ContentDirectory/ContentDirectoryService.cs` (+0 -176) ➖ `Emby.Dlna/ContentDirectory/ContentDirectoryXmlBuilder.cs` (+0 -161) ➖ `Emby.Dlna/ContentDirectory/ControlHandler.cs` (+0 -1735) ➖ `Emby.Dlna/ContentDirectory/ServerItem.cs` (+0 -36) ➖ `Emby.Dlna/ContentDirectory/ServiceActionListBuilder.cs` (+0 -415) ➖ `Emby.Dlna/ContentDirectory/StubType.cs` (+0 -31) ➖ `Emby.Dlna/ControlRequest.cs` (+0 -23) ➖ `Emby.Dlna/ControlResponse.cs` (+0 -26) ➖ `Emby.Dlna/Didl/DidlBuilder.cs` (+0 -1248) _...and 80 more files_ </details> ### 📄 Description **Cumulative Change** DLNA Server, DNLA PlayTo and UPnP (Automatic Port Mapping) have been removed and can be found as plugins at https://github.com/BaronGreenback (at the moment). This is a cumulative change, so the files that are changed will reduce as the subsequent network PR's are accepted. **Known issues** The dashboard errors when DLNA is select. **Breaking change** startupRemoteAccessDto.EnableAutomaticPortMapping is no longer supported as UPnP has been moved to a plugin. **Depends on** PR1: Reduction in code nesting - #4587 PR2: Move AddressOverrideKey into StartupOptions.cs - #4571 PR3: UDP Code - #4543 PR4: Clean up DLNA profiles - #4875 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:15:44 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10193
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?