switch returns

tools.func: Improve GitHub/Codeberg API error handling and error output
Enhance API call robustness and user feedback in misc/tools.func: add explicit handling for HTTP 401 (authentication) and 000/no-response cases, provide clearer error messages and actionable guidance (e.g. export GITHUB_TOKEN, check network/DNS), and preserve retry/backoff logic. Adjusted curl invocation/error capture to avoid echoing sentinel values and updated messages for 403/404/other HTTP errors. Changes touch github_api_call, codeberg_api_call, get_latest_gh_tag, check_for_gh_release, and fetch_and_deploy_gh_release to fail earlier and clean up temp files on errors.
2026-02-26 19:08:28 +03:00 · 2026-02-25 16:37:36 +01:00 · 2026-02-25 16:28:21 +01:00
10 changed files with 97 additions and 145 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -407,14 +407,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 </details>

-## 2026-02-26
-
-### 🚀 Updated Scripts
-
-  - #### ✨ New Features
-
-    - [QOL] Immich: add warning regarding library compilation time [@vhsdream](https://github.com/vhsdream) ([#12345](https://github.com/community-scripts/ProxmoxVE/pull/12345))
-
 ## 2026-02-25

 ### 🆕 New Scripts
@@ -425,10 +417,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

  - #### 🐞 Bug Fixes

-    - fix: overseer migration [@CrazyWolf13](https://github.com/CrazyWolf13) ([#12340](https://github.com/community-scripts/ProxmoxVE/pull/12340))
-    - add: vikunja: daemon reload [@CrazyWolf13](https://github.com/CrazyWolf13) ([#12323](https://github.com/community-scripts/ProxmoxVE/pull/12323))
-    - opnsense-VM: Use ip link to verify bridge existence [@MickLesk](https://github.com/MickLesk) ([#12329](https://github.com/community-scripts/ProxmoxVE/pull/12329))
-    - wger: Use $http_host for proxy Host header [@MickLesk](https://github.com/MickLesk) ([#12327](https://github.com/community-scripts/ProxmoxVE/pull/12327))
    - Passbolt: Update Nginx config `client_max_body_size` [@tremor021](https://github.com/tremor021) ([#12313](https://github.com/community-scripts/ProxmoxVE/pull/12313))
    - Zammad: configure Elasticsearch before zammad start [@MickLesk](https://github.com/MickLesk) ([#12308](https://github.com/community-scripts/ProxmoxVE/pull/12308))

@@ -442,10 +430,6 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

    - Fix detection of ssh keys [@1-tempest](https://github.com/1-tempest) ([#12230](https://github.com/community-scripts/ProxmoxVE/pull/12230))

-  - #### ✨ New Features
-
-    - tools.func: Improve GitHub/Codeberg API error handling and error output [@MickLesk](https://github.com/MickLesk) ([#12330](https://github.com/community-scripts/ProxmoxVE/pull/12330))
-
  - #### 🔧 Refactor

    - core: remove duplicate traps, consolidate error handling and harden signal traps [@MickLesk](https://github.com/MickLesk) ([#12316](https://github.com/community-scripts/ProxmoxVE/pull/12316))
--- a/ct/immich.sh
+++ b/ct/immich.sh
@@ -97,7 +97,7 @@ EOF
  if [[ -f ~/.immich_library_revisions ]]; then
    libraries=("libjxl" "libheif" "libraw" "imagemagick" "libvips")
    cd "$BASE_DIR"
-    msg_warn "Checking for updates to custom image-processing libraries (recompile time: 2-15min per library)"
+    msg_info "Checking for updates to custom image-processing libraries"
    $STD git pull
    for library in "${libraries[@]}"; do
      compile_"$library"
--- a/ct/overseerr.sh
+++ b/ct/overseerr.sh
@@ -28,7 +28,7 @@ function update_script() {
    exit
  fi

-  if [[ -f "$HOME/.overseerr" ]] && [[ "$(printf '%s\n' "1.34.0" "$(cat "$HOME/.overseerr")" | sort -V | head -n1)" == "1.35.0" ]]; then
+  if [[ -f "$HOME/.overseerr" ]] && [[ "$(cat "$HOME/.overseerr")" == "1.34.0" ]]; then
    echo
    echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
    echo "Overseerr v1.34.0 detected."
--- a/ct/vikunja.sh
+++ b/ct/vikunja.sh
@@ -65,7 +65,6 @@ function update_script() {
    msg_ok "Stopped Service"

    fetch_and_deploy_gh_release "vikunja" "go-vikunja/vikunja" "binary"
-    $STD systemctl daemon-reload

    msg_info "Starting Service"
    systemctl start vikunja
--- a/frontend/public/json/github-versions.json
+++ b/frontend/public/json/github-versions.json
@@ -1,5 +1,5 @@
 {
-  "generated": "2026-02-26T06:22:43Z",
+  "generated": "2026-02-25T12:14:52Z",
  "versions": [
    {
      "slug": "2fauth",
@@ -151,9 +151,9 @@
    {
      "slug": "booklore",
      "repo": "booklore-app/BookLore",
-      "version": "v2.0.2",
+      "version": "v2.0.1",
      "pinned": false,
-      "date": "2026-02-25T19:59:20Z"
+      "date": "2026-02-24T04:15:33Z"
    },
    {
      "slug": "bookstack",
@@ -242,9 +242,9 @@
    {
      "slug": "cosmos",
      "repo": "azukaar/Cosmos-Server",
-      "version": "v0.21.0",
+      "version": "v0.20.2",
      "pinned": false,
-      "date": "2026-02-25T17:26:37Z"
+      "date": "2026-01-24T00:12:39Z"
    },
    {
      "slug": "cronicle",
@@ -270,16 +270,16 @@
    {
      "slug": "databasus",
      "repo": "databasus/databasus",
-      "version": "v3.16.3",
+      "version": "v3.16.2",
      "pinned": false,
-      "date": "2026-02-25T19:57:26Z"
+      "date": "2026-02-22T21:10:12Z"
    },
    {
      "slug": "dawarich",
      "repo": "Freika/dawarich",
-      "version": "1.3.0",
+      "version": "1.2.0",
      "pinned": false,
-      "date": "2026-02-25T19:30:25Z"
+      "date": "2026-02-15T22:33:56Z"
    },
    {
      "slug": "discopanel",
@@ -452,9 +452,9 @@
    {
      "slug": "gitea-mirror",
      "repo": "RayLabsHQ/gitea-mirror",
-      "version": "v3.9.5",
+      "version": "v3.9.4",
      "pinned": false,
-      "date": "2026-02-26T05:32:12Z"
+      "date": "2026-02-24T06:17:56Z"
    },
    {
      "slug": "glance",
@@ -606,16 +606,16 @@
    {
      "slug": "invoiceninja",
      "repo": "invoiceninja/invoiceninja",
-      "version": "v5.12.68",
+      "version": "v5.12.66",
      "pinned": false,
-      "date": "2026-02-25T19:38:19Z"
+      "date": "2026-02-24T09:12:50Z"
    },
    {
      "slug": "jackett",
      "repo": "Jackett/Jackett",
-      "version": "v0.24.1218",
+      "version": "v0.24.1205",
      "pinned": false,
-      "date": "2026-02-26T05:55:11Z"
+      "date": "2026-02-25T05:49:14Z"
    },
    {
      "slug": "jellystat",
@@ -627,9 +627,9 @@
    {
      "slug": "joplin-server",
      "repo": "laurent22/joplin",
-      "version": "v3.5.13",
+      "version": "v3.5.12",
      "pinned": false,
-      "date": "2026-02-25T21:19:11Z"
+      "date": "2026-01-17T14:20:33Z"
    },
    {
      "slug": "jotty",
@@ -669,9 +669,9 @@
    {
      "slug": "kimai",
      "repo": "kimai/kimai",
-      "version": "2.50.0",
+      "version": "2.49.0",
      "pinned": false,
-      "date": "2026-02-25T20:13:51Z"
+      "date": "2026-02-15T20:40:19Z"
    },
    {
      "slug": "kitchenowl",
@@ -711,9 +711,9 @@
    {
      "slug": "kubo",
      "repo": "ipfs/kubo",
-      "version": "v0.40.0",
+      "version": "v0.39.0",
      "pinned": false,
-      "date": "2026-02-25T23:16:17Z"
+      "date": "2025-11-27T03:47:38Z"
    },
    {
      "slug": "kutt",
@@ -1166,9 +1166,9 @@
    {
      "slug": "prometheus",
      "repo": "prometheus/prometheus",
-      "version": "v3.10.0",
+      "version": "v3.9.1",
      "pinned": false,
-      "date": "2026-02-26T01:19:51Z"
+      "date": "2026-01-07T17:05:53Z"
    },
    {
      "slug": "prometheus-alertmanager",
@@ -1264,9 +1264,9 @@
    {
      "slug": "radicale",
      "repo": "Kozea/Radicale",
-      "version": "v3.6.1",
+      "version": "v3.6.0",
      "pinned": false,
-      "date": "2026-02-24T06:36:23Z"
+      "date": "2026-01-10T06:56:46Z"
    },
    {
      "slug": "rclone",
@@ -1292,9 +1292,9 @@
    {
      "slug": "recyclarr",
      "repo": "recyclarr/recyclarr",
-      "version": "v8.3.2",
+      "version": "v8.3.1",
      "pinned": false,
-      "date": "2026-02-25T22:39:51Z"
+      "date": "2026-02-25T01:01:31Z"
    },
    {
      "slug": "reitti",
@@ -1390,9 +1390,9 @@
    {
      "slug": "signoz",
      "repo": "SigNoz/signoz-otel-collector",
-      "version": "v0.144.2",
+      "version": "v0.144.1",
      "pinned": false,
-      "date": "2026-02-26T05:57:26Z"
+      "date": "2026-02-25T05:57:17Z"
    },
    {
      "slug": "silverbullet",
@@ -1600,9 +1600,9 @@
    {
      "slug": "tunarr",
      "repo": "chrisbenincasa/tunarr",
-      "version": "v1.1.17",
+      "version": "v1.1.16",
      "pinned": false,
-      "date": "2026-02-25T19:56:36Z"
+      "date": "2026-02-23T21:24:47Z"
    },
    {
      "slug": "uhf",
@@ -1663,9 +1663,9 @@
    {
      "slug": "vikunja",
      "repo": "go-vikunja/vikunja",
-      "version": "v2.0.0",
+      "version": "v1.1.0",
      "pinned": false,
-      "date": "2026-02-25T13:58:47Z"
+      "date": "2026-02-09T10:34:29Z"
    },
    {
      "slug": "wallabag",
@@ -1779,13 +1779,6 @@
      "pinned": false,
      "date": "2026-02-24T15:15:46Z"
    },
-    {
-      "slug": "zerobyte",
-      "repo": "restic/restic",
-      "version": "v0.18.1",
-      "pinned": false,
-      "date": "2025-09-21T18:24:38Z"
-    },
    {
      "slug": "zigbee2mqtt",
      "repo": "Koenkk/zigbee2mqtt",
--- a/frontend/public/json/immich.json
+++ b/frontend/public/json/immich.json
@@ -51,10 +51,6 @@
    {
      "text": "Logs: `/var/log/immich`",
      "type": "info"
-    },
-    {
-      "text": "During first install, 5 custom libraries need to be compiled from source. Depending on your CPU, this can take anywhere between 15 minutes and 2 hours. Please be patient. Touch grass or something.",
-      "type": "warning"
    }
  ]
 }
--- a/install/immich-install.sh
+++ b/install/immich-install.sh
@@ -154,7 +154,7 @@ sed -i -e "/^#shared_preload/s/^#//;/^shared_preload/s/''/'vchord.so'/" /etc/pos
 systemctl restart postgresql.service
 PG_DB_NAME="immich" PG_DB_USER="immich" PG_DB_GRANT_SUPERUSER="true" PG_DB_SKIP_ALTER_ROLE="true" setup_postgresql_db

-msg_warn "Compiling Custom Photo-processing Libraries (can take anywhere from 15min to 2h)"
+msg_info "Compiling Custom Photo-processing Library (extreme patience)"
 LD_LIBRARY_PATH=/usr/local/lib
 export LD_RUN_PATH=/usr/local/lib
 STAGING_DIR=/opt/staging
--- a/install/wger-install.sh
+++ b/install/wger-install.sh
@@ -164,7 +164,7 @@ server {

    location / {
        proxy_pass http://127.0.0.1:8000;
-        proxy_set_header Host $http_host;
+        proxy_set_header Host $host;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_redirect off;
--- a/tools/addon/add-tailscale-lxc.sh
+++ b/tools/addon/add-tailscale-lxc.sh
@@ -76,90 +76,70 @@ grep -q "lxc.mount.entry: /dev/net/tun" "$CTID_CONFIG_PATH" || echo "lxc.mount.e
 header_info
 msg_info "Installing Tailscale in CT $CTID"

-pct exec "$CTID" -- sh -c '
+pct exec "$CTID" -- bash -c '
 set -e
+export DEBIAN_FRONTEND=noninteractive

-# Detect OS inside container
-if [ -f /etc/alpine-release ]; then
-  # ── Alpine Linux ──
-  echo "[INFO] Alpine Linux detected, installing Tailscale via apk..."
+# Source os-release properly (handles quoted values)
+source /etc/os-release

-  # Enable community repo if not already enabled
-  if ! grep -q "^[^#].*community" /etc/apk/repositories 2>/dev/null; then
-    ALPINE_VERSION=$(cat /etc/alpine-release | cut -d. -f1,2)
-    echo "https://dl-cdn.alpinelinux.org/alpine/v${ALPINE_VERSION}/community" >> /etc/apk/repositories
-  fi
+# Fallback if DNS is poisoned or blocked
+ORIG_RESOLV="/etc/resolv.conf"
+BACKUP_RESOLV="/tmp/resolv.conf.backup"

-  apk update
-  apk add --no-cache tailscale
-
-  # Enable and start Tailscale service
-  rc-update add tailscale default 2>/dev/null || true
-  rc-service tailscale start 2>/dev/null || true
-
-else
-  # ── Debian / Ubuntu ──
-  export DEBIAN_FRONTEND=noninteractive
-
-  # Source os-release properly (handles quoted values)
-  . /etc/os-release
-
-  # Fallback if DNS is poisoned or blocked
-  ORIG_RESOLV="/etc/resolv.conf"
-  BACKUP_RESOLV="/tmp/resolv.conf.backup"
-
-  # Check DNS resolution using multiple methods (dig may not be installed)
-  dns_check_failed=true
-  if command -v dig >/dev/null 2>&1; then
-    if dig +short pkgs.tailscale.com 2>/dev/null | grep -qvE "^127\.|^0\.0\.0\.0$|^$"; then
-      dns_check_failed=false
-    fi
-  elif command -v host >/dev/null 2>&1; then
-    if host pkgs.tailscale.com 2>/dev/null | grep -q "has address"; then
-      dns_check_failed=false
-    fi
-  elif command -v nslookup >/dev/null 2>&1; then
-    if nslookup pkgs.tailscale.com 2>/dev/null | grep -q "Address:"; then
-      dns_check_failed=false
-    fi
-  elif command -v getent >/dev/null 2>&1; then
-    if getent hosts pkgs.tailscale.com >/dev/null 2>&1; then
-      dns_check_failed=false
-    fi
-  else
-    # No DNS tools available, try curl directly and assume DNS works
+# Check DNS resolution using multiple methods (dig may not be installed)
+dns_check_failed=true
+if command -v dig &>/dev/null; then
+  if dig +short pkgs.tailscale.com 2>/dev/null | grep -qvE "^127\.|^0\.0\.0\.0$|^$"; then
    dns_check_failed=false
  fi
-
-  if $dns_check_failed; then
-    echo "[INFO] DNS resolution for pkgs.tailscale.com failed (blocked or redirected)."
-    echo "[INFO] Temporarily overriding /etc/resolv.conf with Cloudflare DNS (1.1.1.1)"
-    cp "$ORIG_RESOLV" "$BACKUP_RESOLV"
-    echo "nameserver 1.1.1.1" >"$ORIG_RESOLV"
+elif command -v host &>/dev/null; then
+  if host pkgs.tailscale.com 2>/dev/null | grep -q "has address"; then
+    dns_check_failed=false
  fi
-
-  if ! command -v curl >/dev/null 2>&1; then
-    echo "[INFO] curl not found, installing..."
-    apt-get update -qq
-    apt-get install -y curl >/dev/null
+elif command -v nslookup &>/dev/null; then
+  if nslookup pkgs.tailscale.com 2>/dev/null | grep -q "Address:"; then
+    dns_check_failed=false
  fi
+elif command -v getent &>/dev/null; then
+  if getent hosts pkgs.tailscale.com &>/dev/null; then
+    dns_check_failed=false
+  fi
+else
+  # No DNS tools available, try curl directly and assume DNS works
+  dns_check_failed=false
+fi

-  # Ensure keyrings directory exists
-  mkdir -p /usr/share/keyrings
-
-  curl -fsSL "https://pkgs.tailscale.com/stable/${ID}/${VERSION_CODENAME}.noarmor.gpg" \
-    | tee /usr/share/keyrings/tailscale-archive-keyring.gpg >/dev/null
-
-  echo "deb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/stable/${ID} ${VERSION_CODENAME} main" \
-    >/etc/apt/sources.list.d/tailscale.list
+if $dns_check_failed; then
+  echo "[INFO] DNS resolution for pkgs.tailscale.com failed (blocked or redirected)."
+  echo "[INFO] Temporarily overriding /etc/resolv.conf with Cloudflare DNS (1.1.1.1)"
+  cp "$ORIG_RESOLV" "$BACKUP_RESOLV"
+  echo "nameserver 1.1.1.1" >"$ORIG_RESOLV"
+fi

+if ! command -v curl &>/dev/null; then
+  echo "[INFO] curl not found, installing..."
  apt-get update -qq
-  apt-get install -y tailscale >/dev/null
+ apt update -qq
+ apt install -y curl >/dev/null
+fi

-  if [ -f /tmp/resolv.conf.backup ]; then
-    echo "[INFO] Restoring original /etc/resolv.conf"
-    mv /tmp/resolv.conf.backup /etc/resolv.conf
-  fi
+# Ensure keyrings directory exists
+mkdir -p /usr/share/keyrings
+
+curl -fsSL "https://pkgs.tailscale.com/stable/${ID}/${VERSION_CODENAME}.noarmor.gpg" \
+  | tee /usr/share/keyrings/tailscale-archive-keyring.gpg >/dev/null
+
+echo "deb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/stable/${ID} ${VERSION_CODENAME} main" \
+  >/etc/apt/sources.list.d/tailscale.list
+
+apt-get update -qq
+apt update -qq
+apt install -y tailscale >/dev/null
+
+if [[ -f /tmp/resolv.conf.backup ]]; then
+  echo "[INFO] Restoring original /etc/resolv.conf"
+  mv /tmp/resolv.conf.backup /etc/resolv.conf
 fi
 '

--- a/vm/opnsense-vm.sh
+++ b/vm/opnsense-vm.sh
@@ -288,8 +288,8 @@ function default_settings() {
  echo -e "${DGN}Using Hostname: ${BGN}${HN}${CL}"
  echo -e "${DGN}Allocated Cores: ${BGN}${CORE_COUNT}${CL}"
  echo -e "${DGN}Allocated RAM: ${BGN}${RAM_SIZE}${CL}"
-  if ! ip link show "${BRG}" &>/dev/null; then
-    msg_error "Bridge '${BRG}' does not exist"
+  if ! grep -q "^iface ${BRG}" /etc/network/interfaces; then
+    msg_error "Bridge '${BRG}' does not exist in /etc/network/interfaces"
    exit
  else
    echo -e "${DGN}Using LAN Bridge: ${BGN}${BRG}${CL}"
@@ -305,8 +305,8 @@ function default_settings() {
    if [ "$NETWORK_MODE" = "dual" ]; then
      echo -e "${DGN}Network Mode: ${BGN}Dual Interface (Firewall)${CL}"
      echo -e "${DGN}Using WAN MAC Address: ${BGN}${WAN_MAC}${CL}"
-      if ! ip link show "${WAN_BRG}" &>/dev/null; then
-        msg_error "Bridge '${WAN_BRG}' does not exist"
+      if ! grep -q "^iface ${WAN_BRG}" /etc/network/interfaces; then
+        msg_error "Bridge '${WAN_BRG}' does not exist in /etc/network/interfaces"
        exit
      else
        echo -e "${DGN}Using WAN Bridge: ${BGN}${WAN_BRG}${CL}"
@@ -424,8 +424,8 @@ function advanced_settings() {
    if [ -z $BRG ]; then
      BRG="vmbr0"
    fi
-    if ! ip link show "${BRG}" &>/dev/null; then
-      msg_error "Bridge '${BRG}' does not exist"
+    if ! grep -q "^iface ${BRG}" /etc/network/interfaces; then
+      msg_error "Bridge '${BRG}' does not exist in /etc/network/interfaces"
      exit
    fi
    echo -e "${DGN}Using LAN Bridge: ${BGN}$BRG${CL}"
@@ -474,8 +474,8 @@ function advanced_settings() {
    if [ -z $WAN_BRG ]; then
      WAN_BRG="vmbr1"
    fi
-    if ! ip link show "${WAN_BRG}" &>/dev/null; then
-      msg_error "WAN Bridge '${WAN_BRG}' does not exist"
+    if ! grep -q "^iface ${WAN_BRG}" /etc/network/interfaces; then
+      msg_error "WAN Bridge '${WAN_BRG}' does not exist in /etc/network/interfaces"
      exit
    fi
    echo -e "${DGN}Using WAN Bridge: ${BGN}$WAN_BRG${CL}"