fix(vm): fix LVM/LVM-thin storage and error reporting for all VM scripts

- Add catch-all (*) case to storage type detection in all VM scripts that were missing it (debian-vm, debian-13-vm, ubuntu2204/2404/2504, nextcloud-vm, owncloud-vm, opnsense-vm, pimox-haos-vm) - Add catch-all to mikrotik-routeros (had zfspool but not lvm/lvmthin) - Fix error_handler in ALL 14 VM scripts to send numeric exit_code to post_update_to_api instead of bash command text, which caused 'Unknown error' in telemetry because the API expects a number
fix(archlinux-vm): fix LVM/LVM-thin storage and improve error reporting
2026-02-13 03:14:02 +03:00 · 2026-02-12 17:12:48 +01:00 · 2026-02-12 17:04:39 +01:00 · 2026-02-12 13:51:22 +00:00 · 2026-02-12 13:51:13 +00:00 · 2026-02-12 14:50:56 +01:00
20 changed files with 210 additions and 47 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -407,8 +407,14 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

  - #### 🐞 Bug Fixes

+    - Deluge: add python3-setuptools as dep [@MickLesk](https://github.com/MickLesk) ([#11833](https://github.com/community-scripts/ProxmoxVE/pull/11833))
+    - Dispatcharr: migrate to uv sync [@MickLesk](https://github.com/MickLesk) ([#11831](https://github.com/community-scripts/ProxmoxVE/pull/11831))
    - Pangolin: Update database generation command in install script [@tremor021](https://github.com/tremor021) ([#11825](https://github.com/community-scripts/ProxmoxVE/pull/11825))

+  - #### ✨ New Features
+
+    - Debian13-VM: Optimize First Boot & add noCloud/Cloud Selection [@MickLesk](https://github.com/MickLesk) ([#11810](https://github.com/community-scripts/ProxmoxVE/pull/11810))
+
 ### 💾 Core

  - #### ✨ New Features
--- a/ct/dispatcharr.sh
+++ b/ct/dispatcharr.sh
@@ -104,7 +104,7 @@ function update_script() {
    cd /opt/dispatcharr
    rm -rf .venv
    $STD uv venv --clear
-    $STD uv pip install -r requirements.txt --index-strategy unsafe-best-match
+    $STD uv sync
    $STD uv pip install gunicorn gevent celery redis daphne
    msg_ok "Updated Dispatcharr Backend"

--- a/frontend/public/json/github-versions.json
+++ b/frontend/public/json/github-versions.json
@@ -1,5 +1,5 @@
 {
-  "generated": "2026-02-12T06:25:40Z",
+  "generated": "2026-02-12T12:15:15Z",
  "versions": [
    {
      "slug": "2fauth",
@@ -543,9 +543,9 @@
    {
      "slug": "huntarr",
      "repo": "plexguide/Huntarr.io",
-      "version": "9.2.3",
+      "version": "9.2.4",
      "pinned": false,
-      "date": "2026-02-07T04:44:20Z"
+      "date": "2026-02-12T08:31:23Z"
    },
    {
      "slug": "immich-public-proxy",
@@ -599,9 +599,9 @@
    {
      "slug": "jotty",
      "repo": "fccview/jotty",
-      "version": "1.19.1",
+      "version": "1.20.0",
      "pinned": false,
-      "date": "2026-01-26T21:30:39Z"
+      "date": "2026-02-12T09:23:30Z"
    },
    {
      "slug": "kapowarr",
--- a/install/dispatcharr-install.sh
+++ b/install/dispatcharr-install.sh
@@ -37,7 +37,7 @@ fetch_and_deploy_gh_release "dispatcharr" "Dispatcharr/Dispatcharr" "tarball"
 msg_info "Installing Python Dependencies with uv"
 cd /opt/dispatcharr
 $STD uv venv --clear
-$STD uv pip install -r requirements.txt --index-strategy unsafe-best-match
+$STD uv sync
 $STD uv pip install gunicorn gevent celery redis daphne
 msg_ok "Installed Python Dependencies"

--- a/misc/api.func
+++ b/misc/api.func
@@ -353,6 +353,9 @@ detect_ram() {
 # - Never blocks or fails script execution
 # ------------------------------------------------------------------------------
 post_to_api() {
+  # Prevent duplicate submissions (post_to_api is called from multiple places)
+  [[ "${POST_TO_API_DONE:-}" == "true" ]] && return 0
+
  # Silent fail - telemetry should never break scripts
  command -v curl &>/dev/null || {
    [[ "${DEV_MODE:-}" == "true" ]] && echo "[DEBUG] curl not found, skipping" >&2
@@ -440,6 +443,8 @@ EOF
      -H "Content-Type: application/json" \
      -d "$JSON_PAYLOAD" &>/dev/null || true
  fi
+
+  POST_TO_API_DONE=true
 }

 # ------------------------------------------------------------------------------
@@ -451,6 +456,7 @@ EOF
 #   * ct_type=2 (VM instead of LXC)
 #   * type="vm"
 #   * Disk size without 'G' suffix
+# - Includes hardware detection: CPU, GPU, RAM speed
 # - Only executes if DIAGNOSTICS=yes and RANDOM_UUID is set
 # - Never blocks or fails script execution
 # ------------------------------------------------------------------------------
@@ -473,6 +479,27 @@ post_to_api_vm() {
    pve_version=$(pveversion 2>/dev/null | awk -F'[/ ]' '{print $2}') || true
  fi

+  # Detect GPU if not already set
+  if [[ -z "${GPU_VENDOR:-}" ]]; then
+    detect_gpu
+  fi
+  local gpu_vendor="${GPU_VENDOR:-unknown}"
+  local gpu_model="${GPU_MODEL:-}"
+  local gpu_passthrough="${GPU_PASSTHROUGH:-unknown}"
+
+  # Detect CPU if not already set
+  if [[ -z "${CPU_VENDOR:-}" ]]; then
+    detect_cpu
+  fi
+  local cpu_vendor="${CPU_VENDOR:-unknown}"
+  local cpu_model="${CPU_MODEL:-}"
+
+  # Detect RAM if not already set
+  if [[ -z "${RAM_SPEED:-}" ]]; then
+    detect_ram
+  fi
+  local ram_speed="${RAM_SPEED:-}"
+
  # Remove 'G' suffix from disk size
  local DISK_SIZE_API="${DISK_SIZE%G}"

@@ -492,6 +519,12 @@ post_to_api_vm() {
    "os_version": "${var_version:-}",
    "pve_version": "${pve_version}",
    "method": "${METHOD:-default}",
+    "cpu_vendor": "${cpu_vendor}",
+    "cpu_model": "${cpu_model}",
+    "gpu_vendor": "${gpu_vendor}",
+    "gpu_model": "${gpu_model}",
+    "gpu_passthrough": "${gpu_passthrough}",
+    "ram_speed": "${ram_speed}",
    "repo_source": "${REPO_SOURCE}"
 }
 EOF
--- a/vm/archlinux-vm.sh
+++ b/vm/archlinux-vm.sh
@@ -70,7 +70,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
@@ -203,7 +203,6 @@ function exit-script() {

 function default_settings() {
  VMID=$(get_valid_nextid)
-  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_SIZE="4G"
  DISK_CACHE=""
@@ -259,11 +258,9 @@ function advanced_settings() {
    3>&1 1>&2 2>&3); then
    if [ "$MACH" = q35 ]; then
      echo -e "${CONTAINERTYPE}${BOLD}${DGN}Machine Type: ${BGN}$MACH${CL}"
-      FORMAT=""
      MACHINE=" -machine q35"
    else
      echo -e "${CONTAINERTYPE}${BOLD}${DGN}Machine Type: ${BGN}$MACH${CL}"
-      FORMAT=",efitype=4m"
      MACHINE=""
    fi
  else
@@ -476,31 +473,45 @@ case $STORAGE_TYPE in
 nfs | dir | cifs)
  DISK_EXT=".qcow2"
  DISK_REF="$VMID/"
-  DISK_IMPORT="-format qcow2"
+  DISK_IMPORT="--format qcow2"
  THIN=""
  ;;
 btrfs)
  DISK_EXT=".raw"
  DISK_REF="$VMID/"
-  DISK_IMPORT="-format raw"
-  FORMAT=",efitype=4m"
+  DISK_IMPORT="--format raw"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="--format raw"
+  ;;
 esac
-for i in {0,1}; do
-  disk="DISK$i"
-  eval DISK"${i}"=vm-"${VMID}"-disk-"${i}"${DISK_EXT:-}
-  eval DISK"${i}"_REF="${STORAGE}":"${DISK_REF:-}"${!disk}
-done

 msg_info "Creating a Arch Linux VM"
 qm create $VMID -agent 1${MACHINE} -tablet 0 -localtime 1 -bios ovmf${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \
  -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci
-pvesm alloc $STORAGE $VMID $DISK0 4M 1>&/dev/null
-qm importdisk $VMID ${FILE} $STORAGE ${DISK_IMPORT:-} 1>&/dev/null
+
+if qm disk import --help >/dev/null 2>&1; then
+  IMPORT_CMD=(qm disk import)
+else
+  IMPORT_CMD=(qm importdisk)
+fi
+
+IMPORT_OUT="$("${IMPORT_CMD[@]}" "$VMID" "${FILE}" "$STORAGE" ${DISK_IMPORT:-} 2>&1 || true)"
+DISK_REF_IMPORTED="$(printf '%s\n' "$IMPORT_OUT" | sed -n "s/.*successfully imported disk '\([^']\+\)'.*/\1/p" | tr -d "\r\"'")"
+[[ -z "$DISK_REF_IMPORTED" ]] && DISK_REF_IMPORTED="$(pvesm list "$STORAGE" | awk -v id="$VMID" '$5 ~ ("vm-"id"-disk-") {print $1":"$5}' | sort | tail -n1)"
+[[ -z "$DISK_REF_IMPORTED" ]] && {
+  msg_error "Unable to determine imported disk reference."
+  echo "$IMPORT_OUT"
+  exit 1
+}
+msg_ok "Imported disk (${CL}${BL}${DISK_REF_IMPORTED}${CL})"
+
 qm set $VMID \
-  -efidisk0 ${DISK0_REF}${FORMAT} \
-  -scsi0 ${DISK1_REF},${DISK_CACHE}${THIN}size=${DISK_SIZE} \
+  -efidisk0 ${STORAGE}:0,efitype=4m \
+  -scsi0 ${DISK_REF_IMPORTED},${DISK_CACHE}${THIN%,} \
  -ide2 ${STORAGE}:cloudinit \
  -boot order=scsi0 \
  -serial0 socket >/dev/null
--- a/vm/debian-13-vm.sh
+++ b/vm/debian-13-vm.sh
@@ -70,7 +70,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
@@ -201,6 +201,17 @@ function exit-script() {
  exit
 }

+function select_cloud_init() {
+  if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "CLOUD-INIT" \
+    --yesno "Enable Cloud-Init for VM configuration?\n\nCloud-Init allows automatic configuration of:\n- User accounts and passwords\n- SSH keys\n- Network settings (DHCP/Static)\n- DNS configuration\n\nYou can also configure these settings later in Proxmox UI.\n\nNote: Without Cloud-Init, the nocloud image will be used with console auto-login." --defaultno 18 68); then
+    CLOUD_INIT="yes"
+    echo -e "${CLOUD}${BOLD}${DGN}Cloud-Init: ${BGN}yes${CL}"
+  else
+    CLOUD_INIT="no"
+    echo -e "${CLOUD}${BOLD}${DGN}Cloud-Init: ${BGN}no${CL}"
+  fi
+}
+
 function default_settings() {
  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
@@ -216,7 +227,6 @@ function default_settings() {
  VLAN=""
  MTU=""
  START_VM="yes"
-  CLOUD_INIT="no"
  METHOD="default"
  echo -e "${CONTAINERID}${BOLD}${DGN}Virtual Machine ID: ${BGN}${VMID}${CL}"
  echo -e "${CONTAINERTYPE}${BOLD}${DGN}Machine Type: ${BGN}i440fx${CL}"
@@ -230,7 +240,7 @@ function default_settings() {
  echo -e "${MACADDRESS}${BOLD}${DGN}MAC Address: ${BGN}${MAC}${CL}"
  echo -e "${VLANTAG}${BOLD}${DGN}VLAN: ${BGN}Default${CL}"
  echo -e "${DEFAULT}${BOLD}${DGN}Interface MTU Size: ${BGN}Default${CL}"
-  echo -e "${CLOUD}${BOLD}${DGN}Configure Cloud-init: ${BGN}no${CL}"
+  select_cloud_init
  echo -e "${GATEWAY}${BOLD}${DGN}Start VM when completed: ${BGN}yes${CL}"
  echo -e "${CREATING}${BOLD}${DGN}Creating a Debian 13 VM using the above default settings${CL}"
 }
@@ -400,13 +410,7 @@ function advanced_settings() {
    exit-script
  fi

-  if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "CLOUD-INIT" --yesno "Configure the VM with Cloud-init?" --defaultno 10 58); then
-    echo -e "${CLOUD}${BOLD}${DGN}Configure Cloud-init: ${BGN}yes${CL}"
-    CLOUD_INIT="yes"
-  else
-    echo -e "${CLOUD}${BOLD}${DGN}Configure Cloud-init: ${BGN}no${CL}"
-    CLOUD_INIT="no"
-  fi
+  select_cloud_init

  if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "START VIRTUAL MACHINE" --yesno "Start VM when completed?" 10 58); then
    echo -e "${GATEWAY}${BOLD}${DGN}Start VM when completed: ${BGN}yes${CL}"
@@ -473,6 +477,17 @@ else
 fi
 msg_ok "Using ${CL}${BL}$STORAGE${CL} ${GN}for Storage Location."
 msg_ok "Virtual Machine ID is ${CL}${BL}$VMID${CL}."
+
+# ==============================================================================
+# PREREQUISITES
+# ==============================================================================
+if ! command -v virt-customize &>/dev/null; then
+  msg_info "Installing libguestfs-tools"
+  apt-get update >/dev/null 2>&1
+  apt-get install -y libguestfs-tools >/dev/null 2>&1
+  msg_ok "Installed libguestfs-tools"
+fi
+
 msg_info "Retrieving the URL for the Debian 13 Qcow2 Disk Image"
 if [ "$CLOUD_INIT" == "yes" ]; then
  URL=https://cloud.debian.org/images/cloud/trixie/latest/debian-13-genericcloud-amd64.qcow2
@@ -486,6 +501,50 @@ echo -en "\e[1A\e[0K"
 FILE=$(basename $URL)
 msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"

+# ==============================================================================
+# IMAGE CUSTOMIZATION
+# ==============================================================================
+msg_info "Customizing ${FILE} image"
+
+WORK_FILE=$(mktemp --suffix=.qcow2)
+cp "$FILE" "$WORK_FILE"
+
+# Set hostname
+virt-customize -q -a "$WORK_FILE" --hostname "${HN}" >/dev/null 2>&1
+
+# Prepare for unique machine-id on first boot
+virt-customize -q -a "$WORK_FILE" --run-command "truncate -s 0 /etc/machine-id" >/dev/null 2>&1
+virt-customize -q -a "$WORK_FILE" --run-command "rm -f /var/lib/dbus/machine-id" >/dev/null 2>&1
+
+# Disable systemd-firstboot to prevent interactive prompts blocking the console
+virt-customize -q -a "$WORK_FILE" --run-command "systemctl disable systemd-firstboot.service 2>/dev/null; rm -f /etc/systemd/system/sysinit.target.wants/systemd-firstboot.service; ln -sf /dev/null /etc/systemd/system/systemd-firstboot.service" >/dev/null 2>&1 || true
+
+# Pre-seed firstboot settings so it won't prompt even if triggered
+virt-customize -q -a "$WORK_FILE" --run-command "echo 'Etc/UTC' > /etc/timezone && ln -sf /usr/share/zoneinfo/Etc/UTC /etc/localtime" >/dev/null 2>&1 || true
+virt-customize -q -a "$WORK_FILE" --run-command "touch /etc/locale.conf" >/dev/null 2>&1 || true
+
+if [ "$CLOUD_INIT" == "yes" ]; then
+  # Cloud-Init handles SSH and login
+  virt-customize -q -a "$WORK_FILE" --run-command "sed -i 's/^#*PermitRootLogin.*/PermitRootLogin yes/' /etc/ssh/sshd_config" >/dev/null 2>&1 || true
+  virt-customize -q -a "$WORK_FILE" --run-command "sed -i 's/^#*PasswordAuthentication.*/PasswordAuthentication yes/' /etc/ssh/sshd_config" >/dev/null 2>&1 || true
+else
+  # Configure auto-login on serial console (ttyS0) and virtual console (tty1)
+  virt-customize -q -a "$WORK_FILE" --run-command "mkdir -p /etc/systemd/system/serial-getty@ttyS0.service.d" >/dev/null 2>&1 || true
+  virt-customize -q -a "$WORK_FILE" --run-command 'cat > /etc/systemd/system/serial-getty@ttyS0.service.d/autologin.conf << EOF
+[Service]
+ExecStart=
+ExecStart=-/sbin/agetty --autologin root --noclear %I \$TERM
+EOF' >/dev/null 2>&1 || true
+  virt-customize -q -a "$WORK_FILE" --run-command "mkdir -p /etc/systemd/system/getty@tty1.service.d" >/dev/null 2>&1 || true
+  virt-customize -q -a "$WORK_FILE" --run-command 'cat > /etc/systemd/system/getty@tty1.service.d/autologin.conf << EOF
+[Service]
+ExecStart=
+ExecStart=-/sbin/agetty --autologin root --noclear %I \$TERM
+EOF' >/dev/null 2>&1 || true
+fi
+
+msg_ok "Customized image"
+
 STORAGE_TYPE=$(pvesm status -storage "$STORAGE" | awk 'NR>1 {print $2}')
 case $STORAGE_TYPE in
 nfs | dir)
@@ -501,6 +560,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1}; do
  disk="DISK$i"
@@ -512,7 +576,7 @@ msg_info "Creating a Debian 13 VM"
 qm create $VMID -agent 1${MACHINE} -tablet 0 -localtime 1 -bios ovmf${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \
  -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci
 pvesm alloc $STORAGE $VMID $DISK0 4M 1>&/dev/null
-qm importdisk $VMID ${FILE} $STORAGE ${DISK_IMPORT:-} 1>&/dev/null
+qm importdisk $VMID ${WORK_FILE} $STORAGE ${DISK_IMPORT:-} 1>&/dev/null
 if [ "$CLOUD_INIT" == "yes" ]; then
  qm set $VMID \
    -efidisk0 ${DISK0_REF}${FORMAT} \
@@ -527,6 +591,10 @@ else
    -boot order=scsi0 \
    -serial0 socket >/dev/null
 fi
+
+# Clean up work file
+rm -f "$WORK_FILE"
+
 DESCRIPTION=$(
  cat <<EOF
 <div align='center'>
--- a/vm/debian-vm.sh
+++ b/vm/debian-vm.sh
@@ -70,7 +70,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
@@ -501,6 +501,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1}; do
  disk="DISK$i"
--- a/vm/docker-vm.sh
+++ b/vm/docker-vm.sh
@@ -45,7 +45,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
--- a/vm/haos-vm.sh
+++ b/vm/haos-vm.sh
@@ -74,7 +74,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
--- a/vm/mikrotik-routeros.sh
+++ b/vm/mikrotik-routeros.sh
@@ -71,7 +71,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
@@ -566,6 +566,11 @@ zfspool)
  DISK_REF=""
  DISK_IMPORT="-format raw"
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac

 DISK_VAR="vm-${VMID}-disk-0${DISK_EXT:-}"
--- a/vm/nextcloud-vm.sh
+++ b/vm/nextcloud-vm.sh
@@ -70,7 +70,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
@@ -487,6 +487,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1,2}; do
  disk="DISK$i"
--- a/vm/openwrt-vm.sh
+++ b/vm/openwrt-vm.sh
@@ -74,7 +74,7 @@ function error_handler() {
  local exit_code="$?"
  local line_number="$1"
  local command="$2"
-  post_update_to_api "failed" "$command"
+  post_update_to_api "failed" "$exit_code"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
  echo -e "\n$error_message\n"
  cleanup_vmid
--- a/vm/opnsense-vm.sh
+++ b/vm/opnsense-vm.sh
@@ -48,7 +48,7 @@ function error_handler() {
  local exit_code="$?"
  local line_number="$1"
  local command="$2"
-  post_update_to_api "failed" "$command"
+  post_update_to_api "failed" "$exit_code"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
  echo -e "\n$error_message\n"
  cleanup_vmid
@@ -619,6 +619,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1}; do
  disk="DISK$i"
--- a/vm/owncloud-vm.sh
+++ b/vm/owncloud-vm.sh
@@ -71,7 +71,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
@@ -500,6 +500,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1,2}; do
  disk="DISK$i"
--- a/vm/pimox-haos-vm.sh
+++ b/vm/pimox-haos-vm.sh
@@ -79,7 +79,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
@@ -402,6 +402,11 @@ nfs | dir)
  DISK_REF="$VMID/"
  DISK_IMPORT="-format qcow2"
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1}; do
  disk="DISK$i"
--- a/vm/ubuntu2204-vm.sh
+++ b/vm/ubuntu2204-vm.sh
@@ -66,7 +66,7 @@ function error_handler() {
  local exit_code="$?"
  local line_number="$1"
  local command="$2"
-  post_update_to_api "failed" "$command"
+  post_update_to_api "failed" "$exit_code"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
  echo -e "\n$error_message\n"
  cleanup_vmid
@@ -482,6 +482,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1}; do
  disk="DISK$i"
--- a/vm/ubuntu2404-vm.sh
+++ b/vm/ubuntu2404-vm.sh
@@ -69,7 +69,7 @@ function error_handler() {
  local exit_code="$?"
  local line_number="$1"
  local command="$2"
-  post_update_to_api "failed" "$command"
+  post_update_to_api "failed" "$exit_code"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
  echo -e "\n$error_message\n"
  cleanup_vmid
@@ -484,6 +484,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1}; do
  disk="DISK$i"
--- a/vm/ubuntu2504-vm.sh
+++ b/vm/ubuntu2504-vm.sh
@@ -68,7 +68,7 @@ function error_handler() {
  local exit_code="$?"
  local line_number="$1"
  local command="$2"
-  post_update_to_api "failed" "$command"
+  post_update_to_api "failed" "$exit_code"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
  echo -e "\n$error_message\n"
  cleanup_vmid
@@ -483,6 +483,11 @@ btrfs)
  FORMAT=",efitype=4m"
  THIN=""
  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
 esac
 for i in {0,1}; do
  disk="DISK$i"
--- a/vm/umbrel-os-vm.sh
+++ b/vm/umbrel-os-vm.sh
@@ -69,7 +69,7 @@ function error_handler() {
  local line_number="$1"
  local command="$2"
  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
-  post_update_to_api "failed" "${command}"
+  post_update_to_api "failed" "${exit_code}"
  echo -e "\n$error_message\n"
  cleanup_vmid
 }
Author	SHA1	Message	Date
CanbiZ (MickLesk)	ba93e85eea	fix(vm): fix LVM/LVM-thin storage and error reporting for all VM scripts - Add catch-all (*) case to storage type detection in all VM scripts that were missing it (debian-vm, debian-13-vm, ubuntu2204/2404/2504, nextcloud-vm, owncloud-vm, opnsense-vm, pimox-haos-vm) - Add catch-all to mikrotik-routeros (had zfspool but not lvm/lvmthin) - Fix error_handler in ALL 14 VM scripts to send numeric exit_code to post_update_to_api instead of bash command text, which caused 'Unknown error' in telemetry because the API expects a number	2026-02-12 17:12:48 +01:00
CanbiZ (MickLesk)	663bb828d0	fix(archlinux-vm): fix LVM/LVM-thin storage and improve error reporting - Add catch-all (*) case for storage types (LVM, LVM-thin, zfspool) Previously only nfs/dir/cifs and btrfs were handled, leaving DISK_EXT, DISK_REF, and DISK_IMPORT unset on LVM/LVM-thin storage - Fix error_handler to send numeric exit_code to API instead of bash command text (which caused 'Unknown error' in telemetry) - Replace fragile pvesm alloc for EFI disk with Proxmox-managed :0,efitype=4m (consistent with docker-vm.sh) - Modernize disk import: auto-detect qm disk import vs qm importdisk, parse output to get correct disk reference instead of guessing names - Use --format flag (double dash) consistent with modern Proxmox API - Remove unused FORMAT variable (EFI type now always set correctly) - Remove fragile eval-based disk name construction	2026-02-12 17:04:39 +01:00
community-scripts-pr-app[bot]	79fd0d1dda	Update CHANGELOG.md (#11839 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-02-12 13:51:22 +00:00
community-scripts-pr-app[bot]	280778d53b	Update CHANGELOG.md (#11838 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-02-12 13:51:13 +00:00
CanbiZ (MickLesk)	1c3a3107f1	Deluge: add python3-setuptools as dep (#11833 ) * fix(deluge): add python3-setuptools for pkg_resources on Python 3.13 * Ensure dependencies before updating Deluge	2026-02-12 14:50:56 +01:00
CanbiZ (MickLesk)	ee2c3a20ee	fix(dispatcharr): migrate from requirements.txt to uv sync (pyproject.toml) (#11831 )	2026-02-12 14:50:42 +01:00
CanbiZ (MickLesk)	5ee4f4e34b	fix(api): prevent duplicate post_to_api submissions (#11836 ) Add POST_TO_API_DONE idempotency guard to post_to_api() to prevent the same telemetry record from being submitted twice with the same RANDOM_UUID. This mirrors the existing POST_UPDATE_DONE pattern in post_update_to_api(). post_to_api() is called twice in build.func: - After storage validation (inside CONTAINER_STORAGE check) - After create_lxc_container() completes When both execute, the second call fails with a random_id uniqueness violation on PocketBase, generating server-side errors.	2026-02-12 13:45:32 +01:00
community-scripts-pr-app[bot]	4b0e893bf1	Update CHANGELOG.md (#11834 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-02-12 12:26:51 +00:00
CanbiZ (MickLesk)	3676157a7c	Debian13-VM: Optimize First Boot & add noCloud/Cloud Selection (#11810 ) * fix(debian-13-vm): disable systemd-firstboot and add autologin via virt-customize Newer Debian 13 (Trixie) nocloud images (Jan 29+) have systemd-firstboot enabled, which blocks the boot process by prompting for timezone and root password on the serial console. The noVNC console stalls after auditd checks. Fix by using virt-customize (like docker-vm.sh) to: - Disable systemd-firstboot.service and mask it - Pre-seed timezone to Etc/UTC - Configure autologin on ttyS0 and tty1 for nocloud images - Set hostname and clear machine-id for unique IDs - Install libguestfs-tools if not present Fixes #11807 * feat(debian-13-vm): add cloud-init selection dialog for default and advanced settings Add select_cloud_init() function consistent with docker-vm.sh that prompts the user to choose between Cloud-Init (genericcloud image) and nocloud (with auto-login) in both default and advanced settings. Previously, default settings hardcoded CLOUD_INIT=no without asking.	2026-02-12 13:26:20 +01:00
CanbiZ (MickLesk)	e437e50882	Merge branch 'main' of https://github.com/community-scripts/ProxmoxVE	2026-02-12 13:25:49 +01:00
CanbiZ (MickLesk)	6e9a94b46d	quickfix: missing fields for db	2026-02-12 13:25:42 +01:00
community-scripts-pr-app[bot]	137ae6775e	chore: update github-versions.json (#11832 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-02-12 12:15:25 +00:00