[PR #5923] [MERGED] Styles: Made non-active dark/light css variables exist by default #6599

New Issue

OVERLORD · 2026-02-05T10:36:26+03:00

OVERLORD commented

2026-02-05 10:36:26 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/5923
Author: @ssddanbrown
Created: 11/28/2025
Status: ✅ Merged
Merged: 11/28/2025
Merged by: @ssddanbrown

Base: development ← Head: dark_mode_front

📝 Commits (1)

bb35063 Styles: Made non-active dark/light css variables exist by default

📊 Changes

2 files changed (+31 additions, -11 deletions)

View changed files

📝 resources/views/layouts/parts/custom-styles.blade.php (+18 -11)
📝 tests/Settings/SettingsTest.php (+13 -0)

📄 Description

This means that it would be possible to jump between light/dark mode with just the class, and no reload needed.
Not something we'll directly use right now, but may be useful in customizations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/5923 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 11/28/2025 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `dark_mode_front` --- ### 📝 Commits (1) - [`bb35063`](https://github.com/BookStackApp/BookStack/commit/bb350639c6be27c746ab886c70f620e39eebfa05) Styles: Made non-active dark/light css variables exist by default ### 📊 Changes **2 files changed** (+31 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `resources/views/layouts/parts/custom-styles.blade.php` (+18 -11) 📝 `tests/Settings/SettingsTest.php` (+13 -0) </details> ### 📄 Description This means that it would be possible to jump between light/dark mode with just the class, and no reload needed. Not something we'll directly use right now, but may be useful in customizations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:36:26 +03:00

OVERLORD closed this issue

2026-02-05 10:36:27 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6599