[PR #1929] [CLOSED] [WIP] Email Domain to Role #5923

New Issue

OVERLORD · 2026-02-05T10:20:29+03:00

OVERLORD commented

2026-02-05 10:20:29 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1929
Author: @homotechsual
Created: 3/2/2020
Status: ❌ Closed

Base: master ← Head: email-domain-to-role

📝 Commits (3)

c01f605 UI work for "Email Domain to Role" matching
bd6e8f6 Backend handing for "Email Domain to Role" matching.
1411204 Cleanup some left-over debugging statements!

📊 Changes

6 files changed (+64 additions, -1 deletions)

View changed files

📝 app/Auth/Role.php (+1 -1)
📝 app/Auth/User.php (+18 -0)
📝 app/Http/Controllers/Auth/ConfirmEmailController.php (+2 -0)
➕ database/migrations/2020_03_01_152111_add_role_email_domains.php (+33 -0)
📝 resources/lang/en/settings.php (+3 -0)
📝 resources/views/settings/roles/form.blade.php (+7 -0)

📄 Description

We implemented this over this weekend and decided to open a "Work In Progress" PR to see what/if any feedback there is.

This could do with being a bit more elegant - unfortunately we don't seem to have access to all the roles on the system from the model/auth/user.php level so resorted to passing it to the function invocation. It doesn't feel like the best way to do this!

On the plus side - we're using this in production - running BookStack as a documentation system for our clients who use AzureAD auth in multi-tenant mode to login.

(Tip: If you omit the AZURE_TENANT from the Azure AD config in .env and configure the app appropriately in Azure you'll get a multi-tenant Azure AD setup which allows login from any Azure Tenant.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1929 **Author:** [@homotechsual](https://github.com/homotechsual) **Created:** 3/2/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `email-domain-to-role` --- ### 📝 Commits (3) - [`c01f605`](https://github.com/BookStackApp/BookStack/commit/c01f6053e1827a372bd6e5fe78607e10ed186764) UI work for "Email Domain to Role" matching - [`bd6e8f6`](https://github.com/BookStackApp/BookStack/commit/bd6e8f64c373e8bdabc6cb80a8827ea965576e90) Backend handing for "Email Domain to Role" matching. - [`1411204`](https://github.com/BookStackApp/BookStack/commit/141120418841b11aa9c2bd06b4869dcf2ce2f682) Cleanup some left-over debugging statements! ### 📊 Changes **6 files changed** (+64 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Auth/Role.php` (+1 -1) 📝 `app/Auth/User.php` (+18 -0) 📝 `app/Http/Controllers/Auth/ConfirmEmailController.php` (+2 -0) ➕ `database/migrations/2020_03_01_152111_add_role_email_domains.php` (+33 -0) 📝 `resources/lang/en/settings.php` (+3 -0) 📝 `resources/views/settings/roles/form.blade.php` (+7 -0) </details> ### 📄 Description We implemented this over this weekend and decided to open a "Work In Progress" PR to see what/if any feedback there is. This could do with being a bit more elegant - unfortunately we don't seem to have access to all the roles on the system from the `model/auth/user.php` level so resorted to passing it to the function invocation. It doesn't feel like the best way to do this! On the plus side - we're using this in production - running BookStack as a documentation system for our clients who use AzureAD auth in `multi-tenant` mode to login. (**Tip:** If you omit the `AZURE_TENANT` from the Azure AD config in `.env` and configure the app appropriately in Azure you'll get a multi-tenant Azure AD setup which allows login from any Azure Tenant.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:20:29 +03:00

OVERLORD closed this issue

2026-02-05 10:20:31 +03:00

OVERLORD referenced this issue

2026-02-05 10:36:26 +03:00

[PR #5923] [MERGED] Styles: Made non-active dark/light css variables exist by default #6599

Sign in to join this conversation.