mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-05-04 18:08:46 +03:00
[PR #5914] Fix: Remove validUntil attribute from SAML SP Metadata #6595
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BookStackApp/BookStack/pull/5914
Author: @jdede
Created: 11/24/2025
Status: 🔄 Open
Base:
development← Head:fix-ignoreValidUntil📝 Commits (1)
5967638set ignoreValidUntil to true📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
app/Access/Saml2Service.php(+1 -1)📄 Description
This PR disables the
validUntilattribute in the generated SAML Service Provider (SP) metadata.Why this is needed
Currently, the underlying
php-samllibrary hardcodes the metadata validity (TIME_VALID) to 2 days and caching (TIME_CACHED) to 1 week (Source: Metadata.php).In many real-world scenarios, specifically with Identity Providers like Shibboleth, these default windows are too short. This causes the IdP to deny connections or require manual metadata refreshes once the hardcoded time passes.
The
getSPMetadatafunction in Settings.php allows for an$ignoreValidUntilparameter.getSPMetadatacall to set$ignoreValidUntiltotrue.validUntiltimestamp from the XML generated at<URL>/saml2/metadata, preventing arbitrary expiration issues.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.