[PR #1881] [MERGED] Log failed accesses #5914

New Issue

OVERLORD · 2026-02-05T10:20:15+03:00

OVERLORD commented

2026-02-05 10:20:15 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1881
Author: @benrubson
Created: 2/8/2020
Status: ✅ Merged
Merged: 7/28/2020
Merged by: @ssddanbrown

Base: master ← Head: auth

📝 Commits (4)

12a9a45 Log failed accesses
58df3ad Log failed accesses option
8f1f73d Properly use env/config functions
9d7ce59 Move logFailedAccess into Activity

📊 Changes

4 files changed (+36 additions, -1 deletions)

View changed files

📝 .env.example.complete (+7 -1)
📝 app/Actions/ActivityService.php (+17 -0)
📝 app/Config/logging.php (+5 -0)
📝 app/Http/Controllers/Auth/LoginController.php (+7 -0)

📄 Description

Hi,

This PR logs failed login attempts for further processing by tools such as fail2ban.
It then closes #728.

Thank you 👍

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1881 **Author:** [@benrubson](https://github.com/benrubson) **Created:** 2/8/2020 **Status:** ✅ Merged **Merged:** 7/28/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `auth` --- ### 📝 Commits (4) - [`12a9a45`](https://github.com/BookStackApp/BookStack/commit/12a9a45747f3ce3ff58464cd7ccb88f2c42438e8) Log failed accesses - [`58df3ad`](https://github.com/BookStackApp/BookStack/commit/58df3ad9566061186e62110e7c1e4a4140ed02c2) Log failed accesses option - [`8f1f73d`](https://github.com/BookStackApp/BookStack/commit/8f1f73defa321f026d487b3e9344055746bc6f58) Properly use env/config functions - [`9d7ce59`](https://github.com/BookStackApp/BookStack/commit/9d7ce59b18c5cbeef017349f38f063a63b762188) Move logFailedAccess into Activity ### 📊 Changes **4 files changed** (+36 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.env.example.complete` (+7 -1) 📝 `app/Actions/ActivityService.php` (+17 -0) 📝 `app/Config/logging.php` (+5 -0) 📝 `app/Http/Controllers/Auth/LoginController.php` (+7 -0) </details> ### 📄 Description Hi, This PR logs failed login attempts for further processing by tools such as fail2ban. It then closes #728. Thank you 👍 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:20:15 +03:00

OVERLORD closed this issue

2026-02-05 10:20:18 +03:00

OVERLORD referenced this issue

2026-02-05 10:36:21 +03:00

[PR #5914] Fix: Remove validUntil attribute from SAML SP Metadata #6595

Sign in to join this conversation.