[PR #4389] [MERGED] Comments: Added extra comment-specific activities #6355

Closed
opened 2026-02-05 10:30:07 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4389
Author: @ssddanbrown
Created: 7/18/2023
Status: Merged
Merged: 7/19/2023
Merged by: @ssddanbrown

Base: developmentHead: comment_activity


📝 Commits (3)

  • 422e503 Comments: Added extra comment-specific activities
  • 0359e24 Comments: Updated testing to check for new activities
  • 1c922be Comments: Added text for new activity types

📊 Changes

6 files changed (+34 additions, -10 deletions)

View changed files

📝 app/Activity/ActivityType.php (+4 -0)
📝 app/Activity/CommentRepo.php (+5 -0)
📝 app/Activity/Models/Comment.php (+8 -1)
📝 app/Activity/Tools/ActivityLogger.php (+4 -8)
📝 lang/en/activities.php (+6 -1)
📝 tests/Entity/CommentTest.php (+7 -0)

📄 Description

Kept existing "COMMENTED_ON" activity for upgrade compatibility, specifically for existing webhook usage and for showing comment activities in activity lists.

Precursor to content notifications.

Todo

  • Cover with, or update existing, testing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4389 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 7/18/2023 **Status:** ✅ Merged **Merged:** 7/19/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `comment_activity` --- ### 📝 Commits (3) - [`422e503`](https://github.com/BookStackApp/BookStack/commit/422e50302a05ac6cc0d0a02fa9155b3379ea4ddd) Comments: Added extra comment-specific activities - [`0359e24`](https://github.com/BookStackApp/BookStack/commit/0359e2490a347c2bc245b21535e6939254493767) Comments: Updated testing to check for new activities - [`1c922be`](https://github.com/BookStackApp/BookStack/commit/1c922be4c7b0e32c57511e8875d479b99b763f75) Comments: Added text for new activity types ### 📊 Changes **6 files changed** (+34 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/Activity/ActivityType.php` (+4 -0) 📝 `app/Activity/CommentRepo.php` (+5 -0) 📝 `app/Activity/Models/Comment.php` (+8 -1) 📝 `app/Activity/Tools/ActivityLogger.php` (+4 -8) 📝 `lang/en/activities.php` (+6 -1) 📝 `tests/Entity/CommentTest.php` (+7 -0) </details> ### 📄 Description Kept existing "COMMENTED_ON" activity for upgrade compatibility, specifically for existing webhook usage and for showing comment activities in activity lists. Precursor to content notifications. ### Todo - [x] Cover with, or update existing, testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:30:07 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6355