[PR #4002] [MERGED] Better application color scheme control #6283

New Issue

OVERLORD · 2026-02-05T10:28:27+03:00

OVERLORD commented

2026-02-05 10:28:27 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/4002
Author: @ssddanbrown
Created: 1/28/2023
Status: ✅ Merged
Merged: 1/28/2023
Merged by: @ssddanbrown

Base: development ← Head: color_upgrades

📝 Commits (8)

1f69965 Updated settings view to have dark-mode color options
e708ce9 Updated generic tab styles and js to force accessible usage
65ebdb7 Added usage and defaults for dark colors
c337439 Rolled out use of seperate link color style
1046218 Update JS to show live changes and set light color values
f42ff59 Added migration of color settings to dark mode
7751022 Updated migration to carry across more colors, updated export
631546a Adjusted/improved some color setting wording

📊 Changes

59 files changed (+443 additions, -244 deletions)

View changed files

📝 app/Config/setting-defaults.php (+9 -0)
➕ database/migrations/2023_01_28_141230_copy_color_settings_for_dark_mode.php (+69 -0)
📝 resources/js/components/attachments.js (+1 -1)
📝 resources/js/components/image-manager.js (+3 -4)
📝 resources/js/components/index.js (+1 -1)
➖ resources/js/components/setting-app-color-picker.js (+0 -49)
➕ resources/js/components/setting-app-color-scheme.js (+82 -0)
📝 resources/js/components/setting-color-picker.js (+1 -1)
📝 resources/js/components/tabs.js (+32 -32)
📝 resources/js/services/util.js (+1 -1)
📝 resources/lang/en/settings.php (+6 -4)
📝 resources/sass/_blocks.scss (+7 -0)
📝 resources/sass/_buttons.scss (+3 -7)
📝 resources/sass/_colors.scss (+9 -1)
📝 resources/sass/_components.scss (+24 -23)
📝 resources/sass/_forms.scss (+0 -1)
📝 resources/sass/_header.scss (+0 -3)
📝 resources/sass/_layout.scss (+1 -2)
📝 resources/sass/_text.scss (+2 -2)
📝 resources/sass/_variables.scss (+1 -0)

...and 39 more files

📄 Description

Addition of dark-mode-specific color options, in addition to splitting out link colors from primary app color.
For #3910 and #2314

TODO

- Update tabs to be tagged for accessibility.
- Update css to use link color.
- Update color handling to use dark colors.
- Active dark/light mode on tab press for preview?
- Set defaults for dark colors.
- Migrate existing light settings to dark settings for upgrade stability.
- Test across light and dark mode.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/4002 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 1/28/2023 **Status:** ✅ Merged **Merged:** 1/28/2023 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `color_upgrades` --- ### 📝 Commits (8) - [`1f69965`](https://github.com/BookStackApp/BookStack/commit/1f69965c1e61a6ef3d46eb46ef4290889ba34381) Updated settings view to have dark-mode color options - [`e708ce9`](https://github.com/BookStackApp/BookStack/commit/e708ce93baa19715b0951c86c111320d4af2dc82) Updated generic tab styles and js to force accessible usage - [`65ebdb7`](https://github.com/BookStackApp/BookStack/commit/65ebdb72345b5afc7d98d750a599efc1943cdaea) Added usage and defaults for dark colors - [`c337439`](https://github.com/BookStackApp/BookStack/commit/c3374393703b55d5c9efa54870c760b8899ceeeb) Rolled out use of seperate link color style - [`1046218`](https://github.com/BookStackApp/BookStack/commit/104621841be7e8a8ba2774a6d5925117cde2b9ec) Update JS to show live changes and set light color values - [`f42ff59`](https://github.com/BookStackApp/BookStack/commit/f42ff59b4376493b8c4b30558f017d24a71dd75e) Added migration of color settings to dark mode - [`7751022`](https://github.com/BookStackApp/BookStack/commit/7751022c66134877eab405c6bb77ad92a4221523) Updated migration to carry across more colors, updated export - [`631546a`](https://github.com/BookStackApp/BookStack/commit/631546a68aa2e1d60f547919dc45345a7d1adfbe) Adjusted/improved some color setting wording ### 📊 Changes **59 files changed** (+443 additions, -244 deletions) <details> <summary>View changed files</summary> 📝 `app/Config/setting-defaults.php` (+9 -0) ➕ `database/migrations/2023_01_28_141230_copy_color_settings_for_dark_mode.php` (+69 -0) 📝 `resources/js/components/attachments.js` (+1 -1) 📝 `resources/js/components/image-manager.js` (+3 -4) 📝 `resources/js/components/index.js` (+1 -1) ➖ `resources/js/components/setting-app-color-picker.js` (+0 -49) ➕ `resources/js/components/setting-app-color-scheme.js` (+82 -0) 📝 `resources/js/components/setting-color-picker.js` (+1 -1) 📝 `resources/js/components/tabs.js` (+32 -32) 📝 `resources/js/services/util.js` (+1 -1) 📝 `resources/lang/en/settings.php` (+6 -4) 📝 `resources/sass/_blocks.scss` (+7 -0) 📝 `resources/sass/_buttons.scss` (+3 -7) 📝 `resources/sass/_colors.scss` (+9 -1) 📝 `resources/sass/_components.scss` (+24 -23) 📝 `resources/sass/_forms.scss` (+0 -1) 📝 `resources/sass/_header.scss` (+0 -3) 📝 `resources/sass/_layout.scss` (+1 -2) 📝 `resources/sass/_text.scss` (+2 -2) 📝 `resources/sass/_variables.scss` (+1 -0) _...and 39 more files_ </details> ### 📄 Description Addition of dark-mode-specific color options, in addition to splitting out link colors from primary app color. For #3910 and #2314 ### TODO - [x] - Update tabs to be tagged for accessibility. - [x] - Update css to use link color. - [x] - Update color handling to use dark colors. - [x] - Active dark/light mode on tab press for preview? - [x] - Set defaults for dark colors. - [x] - Migrate existing light settings to dark settings for upgrade stability. - [x] - Test across light and dark mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:28:27 +03:00

OVERLORD closed this issue

2026-02-05 10:28:30 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6283