mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 19:06:06 +03:00
Right to create in the shelf #3910
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @twrona on GitHub (Jul 10, 2023).
Describe the Bug
The right to create no longer appears in the shelf permissions, but on the books. Since it is not present on the shelves, it cannot be propagated on the books.
Steps to Reproduce
Go to shelf permissions. Compare with book permissions
Expected Behaviour
Have the right to create on the bookshelf to automatically propagate to the books on the shelf
Screenshots or Additional Context
Sur étagères :
Sur les livres sous cette étagère :
Browser Details
No response
Exact BookStack Version
BookStack v23.06
PHP Version
No response
Hosting Environment
Ubuntu 22.04
@twrona commented on GitHub (Jul 10, 2023):
on another bookstack in version BookStack v23.05.2 the parameter appears on the shelf permissions.
@ssddanbrown commented on GitHub (Jul 10, 2023):
Thanks for raising @twrona.
My apologies, this appears to be an oversight on my part.
The shelf create permission option was removed as it was thought to be useless, since they didn't have any direct functionality.
I completely missed the use-case of these permissions being used via the "Copy Permissions to Books" functionality.
I'll assign this to a new patch release and look to get something out within the next few days.
@twrona commented on GitHub (Jul 10, 2023):
Thank you very much for your prompt reply.
In fact, it was useful for me to automatically push bookshelf permissions every hour to avoid overloading books by users.
Looking forward to the correction, thank you very much.
@ssddanbrown commented on GitHub (Jul 13, 2023):
Okay, have now applied
ae834050f5to revert the permission removal, and have added a notice instead to indicate the limited use-case of this permission action.Apologies again for this. Unfortunately existing shelf-create permissions would have been removed upon previous upgrade, so you'll have to re-check this create permission for any applicable shelves.
I'll be releasing v23.06.2 shortly with this patch included within.
@ssddanbrown commented on GitHub (Jul 13, 2023):
@joaomezzari Tagging you for visibility of my last message since you were also affected by this.