[PR #3349] [MERGED] Reorganization of settings view #6179

Closed
opened 2026-02-05 10:26:16 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3349
Author: @ssddanbrown
Created: 3/27/2022
Status: Merged
Merged: 3/28/2022
Merged by: @ssddanbrown

Base: developmentHead: settings_reorg


📝 Commits (3)

  • 31dbf13 Started playing with new settings view layout
  • 895f656 Split out settings view and made functional
  • 7c12920 Added 404 response for non-existing setting categories

📊 Changes

36 files changed (+426 additions, -381 deletions)

View changed files

📝 app/Http/Controllers/SettingController.php (+20 -13)
resources/icons/palette.svg (+1 -0)
📝 resources/lang/en/settings.php (+2 -0)
📝 resources/sass/_layout.scss (+3 -0)
📝 resources/sass/_lists.scss (+12 -2)
📝 resources/views/settings/audit.blade.php (+1 -5)
resources/views/settings/customization.blade.php (+137 -0)
resources/views/settings/features.blade.php (+66 -0)
resources/views/settings/index.blade.php (+0 -278)
resources/views/settings/layout.blade.php (+37 -0)
📝 resources/views/settings/maintenance.blade.php (+1 -1)
resources/views/settings/parts/navbar-with-version.blade.php (+0 -17)
📝 resources/views/settings/parts/navbar.blade.php (+1 -1)
📝 resources/views/settings/recycle-bin/destroy.blade.php (+1 -3)
📝 resources/views/settings/recycle-bin/index.blade.php (+1 -3)
📝 resources/views/settings/recycle-bin/restore.blade.php (+1 -3)
resources/views/settings/registration.blade.php (+71 -0)
📝 resources/views/settings/roles/create.blade.php (+1 -3)
📝 resources/views/settings/roles/delete.blade.php (+1 -3)
📝 resources/views/settings/roles/edit.blade.php (+1 -3)

...and 16 more files

📄 Description

Related to #3221

Todo

  • Land on a design
  • Move out added text to translations
  • Update tests to cover

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3349 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 3/27/2022 **Status:** ✅ Merged **Merged:** 3/28/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `settings_reorg` --- ### 📝 Commits (3) - [`31dbf13`](https://github.com/BookStackApp/BookStack/commit/31dbf132b932bd0777edc87605f62c3681d94b32) Started playing with new settings view layout - [`895f656`](https://github.com/BookStackApp/BookStack/commit/895f656897c70190b8e0a4e426a56b9df83a23b2) Split out settings view and made functional - [`7c12920`](https://github.com/BookStackApp/BookStack/commit/7c12920dc8c0ec0b6a948526f3bc10ff6c69fcd1) Added 404 response for non-existing setting categories ### 📊 Changes **36 files changed** (+426 additions, -381 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/SettingController.php` (+20 -13) ➕ `resources/icons/palette.svg` (+1 -0) 📝 `resources/lang/en/settings.php` (+2 -0) 📝 `resources/sass/_layout.scss` (+3 -0) 📝 `resources/sass/_lists.scss` (+12 -2) 📝 `resources/views/settings/audit.blade.php` (+1 -5) ➕ `resources/views/settings/customization.blade.php` (+137 -0) ➕ `resources/views/settings/features.blade.php` (+66 -0) ➖ `resources/views/settings/index.blade.php` (+0 -278) ➕ `resources/views/settings/layout.blade.php` (+37 -0) 📝 `resources/views/settings/maintenance.blade.php` (+1 -1) ➖ `resources/views/settings/parts/navbar-with-version.blade.php` (+0 -17) 📝 `resources/views/settings/parts/navbar.blade.php` (+1 -1) 📝 `resources/views/settings/recycle-bin/destroy.blade.php` (+1 -3) 📝 `resources/views/settings/recycle-bin/index.blade.php` (+1 -3) 📝 `resources/views/settings/recycle-bin/restore.blade.php` (+1 -3) ➕ `resources/views/settings/registration.blade.php` (+71 -0) 📝 `resources/views/settings/roles/create.blade.php` (+1 -3) 📝 `resources/views/settings/roles/delete.blade.php` (+1 -3) 📝 `resources/views/settings/roles/edit.blade.php` (+1 -3) _...and 16 more files_ </details> ### 📄 Description Related to #3221 #### Todo - [x] Land on a design - [x] Move out added text to translations - [x] Update tests to cover --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:26:16 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6179